FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: skip annotations if not in __fields__ by NarekA · Pull Request #1779 · docarray/docarray · GitHub

/ docarray Public

fix: skip annotations if not in __fields__ - #1779

Closed
NarekA wants to merge 1 commit into
docarray:mainfrom
NarekA:fix-skip-annotations-not-in-field-narek
ConversationCommits (1)ChecksFiles changed
Closed

fix: skip annotations if not in __fields__#1779
NarekA wants to merge 1 commit into
docarray:mainfrom
NarekA:fix-skip-annotations-not-in-field-narek

Conversation

NarekA commented Sep 6, 2023

Copy link
Copy Markdown

Porting #1777

@JoanFM

NarekA mentioned this pull request Sep 6, 2023
Merged

JoanFM commented Sep 6, 2023

Copy link
Copy Markdown
Member

Hey @NarekA here we need you to signoff ur commits. Could you do this please?

codecov Bot commented Sep 6, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Patch coverage: 100.00% and project coverage change: -3.02% ⚠️

Comparison is base (189ff63) 84.99% compared to head (9c84e54) 81.98%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1779      +/-   ##
==========================================
- Coverage   84.99%   81.98%   -3.02%     
==========================================
  Files         134      134              
  Lines        8845     8847       +2     
==========================================
- Hits         7518     7253     -265     
- Misses       1327     1594     +267
Flag Coverage Δ
docarray 81.98% <100.00%> (-3.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
docarray/utils/create_dynamic_doc_class.py 84.00% <100.00%> (+0.32%) ⬆️

... and 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

NarekA force-pushed the fix-skip-annotations-not-in-field-narek branch 3 times, most recently from 4c97fe4 to 3b105bd Compare September 6, 2023 18:27
fix: skip annotations if not in __fields__
9c84e54 
Signed-off-by: Nareka <amirbekiann@gmail.com>
NarekA force-pushed the fix-skip-annotations-not-in-field-narek branch from 3b105bd to 9c84e54 Compare September 6, 2023 18:45

NarekA commented Sep 6, 2023

Copy link
Copy Markdown
Author

@JoanFM I can't figure out signing github commits, why don't you just merge your branch. I'm giving up on this one.

JoanFM commented Sep 7, 2023

Copy link
Copy Markdown
Member

@JoanFM I can't figure out signing github commits, why don't you just merge your branch. I'm giving up on this one.

Done

JoanFM closed this Sep 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL