feat: remove JAC - #1791
Merged
JoanFM merged 4 commits intoSep 18, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
JoanFM
force-pushed
the
feat-remove-jac-store
branch
from
4867c58 to
b42de4e
Compare
September 15, 2023 16:25
Copy link
Copy Markdown
Codecov ReportPatch coverage: 100.00% and project coverage change: -0.66% ⚠️ Additional details and impacted files @@ Coverage Diff @@
## main #1791 +/- ##
==========================================
- Coverage 85.46% 84.80% -0.66%
==========================================
Files 136 135 -1
Lines 9046 8899 -147
==========================================
- Hits 7731 7547 -184
- Misses 1315 1352 +37
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes ☔ View full report in Codecov by Sentry. |
Sorry, something went wrong.
JoanFM
force-pushed
the
feat-remove-jac-store
branch
from
b42de4e to
964bbc1
Compare
September 15, 2023 16:41
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
JoanFM
force-pushed
the
feat-remove-jac-store
branch
from
964bbc1 to
75f98f5
Compare
September 15, 2023 16:41
added 3 commits
September 15, 2023 18:56
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
Copy link
Copy Markdown
|
📝 Docs are deployed on https://ft-feat-remove-jac-store--jina-docs.netlify.app 🎉 |
Sorry, something went wrong.
samsja
approved these changes
Sep 18, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Jina AI Cloud is going to be stopped, JACStore will not work anymore, this PR removes it