fix: fix double subscriptable error - #1800
Merged
JoanFM merged 3 commits intoSep 27, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
6 tasks
JoanFM
force-pushed
the
fix-double-subscriptable
branch
from
4e2d529 to
1e90e6d
Compare
September 19, 2023 21:55
Copy link
Copy Markdown
Codecov ReportAll modified lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## main #1800 +/- ##
==========================================
+ Coverage 84.12% 84.13% +0.01%
==========================================
Files 135 135
Lines 8906 8908 +2
==========================================
+ Hits 7492 7495 +3
+ Misses 1414 1413 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes ☔ View full report in Codecov by Sentry. |
Sorry, something went wrong.
Comment thread
tests/units/array/test_array.py
Outdated
JoanFM
force-pushed
the
fix-double-subscriptable
branch
from
1e90e6d to
2ab4f9d
Compare
September 20, 2023 19:34
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
JoanFM
force-pushed
the
fix-double-subscriptable
branch
from
2ab4f9d to
fc41eb0
Compare
September 20, 2023 19:39
Signed-off-by: Joan Fontanals <joan.martinez@jina.ai>
samsja
approved these changes
Sep 27, 2023
Copy link
Copy Markdown
|
📝 Docs are deployed on https://ft-fix-double-subscriptable--jina-docs.netlify.app 🎉 |
Sorry, something went wrong.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.