feat: add BaseDocWoId - #1803
Merged
samsja merged 5 commits intoSep 26, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
Copy link
Copy Markdown
Codecov ReportAll modified lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## main #1803 +/- ##
===========================================
- Coverage 84.81% 73.89% -10.93%
===========================================
Files 135 135
Lines 8904 8905 +1
===========================================
- Hits 7552 6580 -972
- Misses 1352 2325 +973
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 31 files with indirect coverage changes ☔ View full report in Codecov by Sentry. |
Sorry, something went wrong.
deepankarm
approved these changes
Sep 25, 2023
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
JoanFM
requested changes
Sep 26, 2023
Comment thread
docarray/base_doc/doc.py
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
Copy link
Copy Markdown
|
📝 Docs are deployed on https://ft-feat-doc-wo-id--jina-docs.netlify.app 🎉 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
allow to have doc without Id