fix: allow nested model dump via docvec - #1808
Merged
JoanFM merged 3 commits intoSep 28, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
Copy link
Copy Markdown
Codecov ReportAll modified lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## main #1808 +/- ##
==========================================
+ Coverage 84.26% 84.56% +0.30%
==========================================
Files 135 135
Lines 8971 8979 +8
==========================================
+ Hits 7559 7593 +34
+ Misses 1412 1386 -26
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes ☔ View full report in Codecov by Sentry. |
Sorry, something went wrong.
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
Copy link
Copy Markdown
|
📝 Docs are deployed on https://ft-fix-nested-model-dump--jina-docs.netlify.app 🎉 |
Sorry, something went wrong.
JoanFM
marked this pull request as ready for review
September 28, 2023 15:32
JoanFM
approved these changes
Sep 28, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
DocVec nested document could not serialize correctly using model_dump from pydantic v2.
This pr fix it by recursively deep copying the document whereas before it was just done at level 1