FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: allow config extension in pydantic v2 by samsja · Pull Request #1814 · docarray/docarray · GitHub

fix: allow config extension in pydantic v2 - #1814

Merged
JoanFM merged 3 commits into
mainfrom
fix-config
Oct 2, 2023
Merged

fix: allow config extension in pydantic v2#1814
JoanFM merged 3 commits into
mainfrom
fix-config

Conversation

samsja commented Sep 29, 2023

Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
samsja requested a review from JoanFM September 29, 2023 13:11

Copy link
Copy Markdown

📝 Docs are deployed on https://ft-fix-config--jina-docs.netlify.app 🎉

codecov Bot commented Sep 29, 2023
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (9a6b1e6) 84.61% compared to head (642c266) 84.62%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1814   +/-   ##
=======================================
  Coverage   84.61%   84.62%           
=======================================
  Files         135      135           
  Lines        9005     9006    +1     
=======================================
+ Hits         7620     7621    +1     
  Misses       1385     1385           
Flag Coverage Δ
docarray 84.62% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
docarray/base_doc/doc.py 92.18% <100.00%> (ø)
docarray/base_doc/mixins/io.py 90.24% <100.00%> (+0.04%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

JoanFM merged commit 3da3603 into main Oct 2, 2023
JoanFM deleted the fix-config branch October 2, 2023 07:30
JoanFM mentioned this pull request Oct 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[pydantic v2] Override config is not working Add pydantic v2 compatiblity

2 participants


Back | FazBrowse Home | New Git URL