FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: fix create pure python class iteratively by JoanFM · Pull Request #1867 · docarray/docarray · GitHub

/ docarray Public

fix: fix create pure python class iteratively #1867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoanFM merged 1 commit into from
Feb 15, 2024
Conversation 2 Commits 1 Checks 0 Files changed
Merged

fix: fix create pure python class iteratively #1867

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .py  (2) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
3 changes: 2 additions & 1 deletion docarray/utils/create_dynamic_doc_class.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,8 @@ class MyDoc(BaseDoc):
try:
if safe_issubclass(field, DocList):
t: Any = field.doc_type
fields[field_name] = (List[t], field_info)
t_aux = create_pure_python_type_model(t)
fields[field_name] = (List[t_aux], field_info)
else:
fields[field_name] = (field, field_info)
except TypeError:
Expand Down
30 changes: 30 additions & 0 deletions tests/units/util/test_create_dynamic_code_class.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -285,3 +285,33 @@ class CustomDoc(BaseDoc):
new_custom_doc_model.schema().get('description')
== 'Here I have the description of the class'
)


def test_dynamic_class_creation_multiple_doclist_nested():
from docarray import BaseDoc, DocList

class MyTextDoc(BaseDoc):
text: str

class QuoteFile(BaseDoc):
texts: DocList[MyTextDoc]

class SearchResult(BaseDoc):
results: DocList[QuoteFile] = None

models_created_by_name = {}
SearchResult_aux = create_pure_python_type_model(SearchResult)
_ = create_base_doc_from_schema(
SearchResult_aux.schema(), 'SearchResult', models_created_by_name
)
QuoteFile_reconstructed_in_gateway_from_Search_results = models_created_by_name[
'QuoteFile'
]
textlist = DocList[models_created_by_name['MyTextDoc']](
[models_created_by_name['MyTextDoc'](id='11', text='hey')]
)

reconstructed_in_gateway_from_Search_results = (
QuoteFile_reconstructed_in_gateway_from_Search_results(id='0', texts=textlist)
)
assert reconstructed_in_gateway_from_Search_results.texts[0].text == 'hey'
Back | FazBrowse Home | New Git URL