feat: torch tensor type - #800
Merged
samsja merged 13 commits intoNov 17, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…tte-v2 # Conflicts: # docarray/document/mixins/proto.py # docarray/typing/ndarray.py # docarray/typing/tensor/__init__.py # docarray/typing/tensor/tensor.py # docarray/typing/url/image_url.py # tests/integrations/typing/tensor.py # tests/units/document/proto/test_proto_based_object.py # tests/units/typing/test_image_url.py
JohannesMessner
force-pushed
the
feat-torch-tensor
branch
from
f1d2692 to
19136ed
Compare
November 16, 2022 10:01
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
JohannesMessner
force-pushed
the
feat-torch-tensor
branch
from
19136ed to
e820675
Compare
November 16, 2022 10:05
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
Closed
samsja
reviewed
Nov 16, 2022
samsja
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
minor comment
Sorry, something went wrong.
Comment thread
docarray/typing/tensor/torch_tensor.py
Outdated
Co-authored-by: samsja <55492238+samsja@users.noreply.github.com> Signed-off-by: Johannes Messner <44071807+JohannesMessner@users.noreply.github.com>
samsja
approved these changes
Nov 16, 2022
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
samsja
added a commit
that referenced
this pull request
Nov 17, 2022
* feat: add tensor type for ndarray * fix: fix mypy typing * feat: torch tensor type Signed-off-by: Johannes Messner <messnerjo@gmail.com> * fix: protobuf for pytorch type Signed-off-by: Johannes Messner <messnerjo@gmail.com> * ci: install all extras in the ci Signed-off-by: Johannes Messner <messnerjo@gmail.com> * refactor: make nice looking * docs: update docarray/typing/tensor/torch_tensor.py Co-authored-by: samsja <55492238+samsja@users.noreply.github.com> Signed-off-by: Johannes Messner <44071807+JohannesMessner@users.noreply.github.com> * refactor: code style Signed-off-by: Johannes Messner <messnerjo@gmail.com> * fix: black and mypy Signed-off-by: Johannes Messner <messnerjo@gmail.com> * fix: suppress mypy import error * ci: fix ci install Signed-off-by: Johannes Messner <messnerjo@gmail.com> Signed-off-by: Johannes Messner <messnerjo@gmail.com> Signed-off-by: Johannes Messner <44071807+JohannesMessner@users.noreply.github.com> Co-authored-by: samsja <55492238+samsja@users.noreply.github.com>
samsja
added a commit
that referenced
this pull request
Nov 17, 2022
* feat: add tensor type for ndarray * fix: fix mypy typing * feat: torch tensor type Signed-off-by: Johannes Messner <messnerjo@gmail.com> * fix: protobuf for pytorch type Signed-off-by: Johannes Messner <messnerjo@gmail.com> * ci: install all extras in the ci Signed-off-by: Johannes Messner <messnerjo@gmail.com> * refactor: make nice looking * docs: update docarray/typing/tensor/torch_tensor.py Co-authored-by: samsja <55492238+samsja@users.noreply.github.com> Signed-off-by: Johannes Messner <44071807+JohannesMessner@users.noreply.github.com> * refactor: code style Signed-off-by: Johannes Messner <messnerjo@gmail.com> * fix: black and mypy Signed-off-by: Johannes Messner <messnerjo@gmail.com> * fix: suppress mypy import error * ci: fix ci install Signed-off-by: Johannes Messner <messnerjo@gmail.com> Signed-off-by: Johannes Messner <messnerjo@gmail.com> Signed-off-by: Johannes Messner <44071807+JohannesMessner@users.noreply.github.com> Co-authored-by: samsja <55492238+samsja@users.noreply.github.com>
JohannesMessner
added a commit
that referenced
this pull request
Nov 23, 2022
* feat: allow da bulk access to return da for document Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * fix: fix mypy type pb Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * fix: add link to the mypy issue Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * fix: remove useless list type hint Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * feat: torch tensor type (#800) * feat: add tensor type for ndarray * fix: fix mypy typing * feat: torch tensor type Signed-off-by: Johannes Messner <messnerjo@gmail.com> * fix: protobuf for pytorch type Signed-off-by: Johannes Messner <messnerjo@gmail.com> * ci: install all extras in the ci Signed-off-by: Johannes Messner <messnerjo@gmail.com> * refactor: make nice looking * docs: update docarray/typing/tensor/torch_tensor.py Co-authored-by: samsja <55492238+samsja@users.noreply.github.com> Signed-off-by: Johannes Messner <44071807+JohannesMessner@users.noreply.github.com> * refactor: code style Signed-off-by: Johannes Messner <messnerjo@gmail.com> * fix: black and mypy Signed-off-by: Johannes Messner <messnerjo@gmail.com> * fix: suppress mypy import error * ci: fix ci install Signed-off-by: Johannes Messner <messnerjo@gmail.com> Signed-off-by: Johannes Messner <messnerjo@gmail.com> Signed-off-by: Johannes Messner <44071807+JohannesMessner@users.noreply.github.com> Co-authored-by: samsja <55492238+samsja@users.noreply.github.com> * feat: add fastapi to dependency Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * feat(wip): add fake method to dump tensor to json Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * feat(wip): add fastapi test Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * feat: add json dump for type and document Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * feat: add json compatible with orjson Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * refactor: clean tests Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * fix: remove duplicate Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * fix: better json schema for tensor Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * fix: fix fast api test Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * refactor: move to json test to integration Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * fix: json laod from tensor type now working Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * fix: add tensor to fastapi test Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * fix: add new fastapi test Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * fix: fix mypy Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * feat: add more testing for text uri about json Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * fix: fix default orson not returning Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * fix: apply johannes suggestion on docstring Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * fix: does not perform copy anymore on torch tensor unwrap Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * fix: add johannes suggestion Co-authored-by: Johannes Messner <44071807+JohannesMessner@users.noreply.github.com> Signed-off-by: samsja <55492238+samsja@users.noreply.github.com> * fix: fix ruff line lenght Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * fix: fix mypy pb Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> Signed-off-by: Johannes Messner <messnerjo@gmail.com> Signed-off-by: Johannes Messner <44071807+JohannesMessner@users.noreply.github.com> Signed-off-by: samsja <55492238+samsja@users.noreply.github.com> Co-authored-by: Johannes Messner <44071807+JohannesMessner@users.noreply.github.com>
dongxiang123
pushed a commit
that referenced
this pull request
Nov 23, 2022
* feat: allow da bulk access to return da for document Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * fix: fix mypy type pb Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * fix: add link to the mypy issue Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * fix: remove useless list type hint Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * feat: torch tensor type (#800) * feat: add tensor type for ndarray * fix: fix mypy typing * feat: torch tensor type Signed-off-by: Johannes Messner <messnerjo@gmail.com> * fix: protobuf for pytorch type Signed-off-by: Johannes Messner <messnerjo@gmail.com> * ci: install all extras in the ci Signed-off-by: Johannes Messner <messnerjo@gmail.com> * refactor: make nice looking * docs: update docarray/typing/tensor/torch_tensor.py Co-authored-by: samsja <55492238+samsja@users.noreply.github.com> Signed-off-by: Johannes Messner <44071807+JohannesMessner@users.noreply.github.com> * refactor: code style Signed-off-by: Johannes Messner <messnerjo@gmail.com> * fix: black and mypy Signed-off-by: Johannes Messner <messnerjo@gmail.com> * fix: suppress mypy import error * ci: fix ci install Signed-off-by: Johannes Messner <messnerjo@gmail.com> Signed-off-by: Johannes Messner <messnerjo@gmail.com> Signed-off-by: Johannes Messner <44071807+JohannesMessner@users.noreply.github.com> Co-authored-by: samsja <55492238+samsja@users.noreply.github.com> * feat: add fastapi to dependency Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * feat(wip): add fake method to dump tensor to json Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * feat(wip): add fastapi test Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * feat: add json dump for type and document Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * feat: add json compatible with orjson Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * refactor: clean tests Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * fix: remove duplicate Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * fix: better json schema for tensor Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * fix: fix fast api test Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * refactor: move to json test to integration Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * fix: json laod from tensor type now working Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * fix: add tensor to fastapi test Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * fix: add new fastapi test Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * fix: fix mypy Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * feat: add more testing for text uri about json Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * fix: fix default orson not returning Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * fix: apply johannes suggestion on docstring Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * fix: does not perform copy anymore on torch tensor unwrap Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * fix: add johannes suggestion Co-authored-by: Johannes Messner <44071807+JohannesMessner@users.noreply.github.com> Signed-off-by: samsja <55492238+samsja@users.noreply.github.com> * fix: fix ruff line lenght Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> * fix: fix mypy pb Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> Signed-off-by: Sami Jaghouar <sami.jaghouar@hotmail.fr> Signed-off-by: Johannes Messner <messnerjo@gmail.com> Signed-off-by: Johannes Messner <44071807+JohannesMessner@users.noreply.github.com> Signed-off-by: samsja <55492238+samsja@users.noreply.github.com> Co-authored-by: Johannes Messner <44071807+JohannesMessner@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals:
Add type TorchTensor as wrapper around torch.Tensor.
closes #783