FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

refactor(v2): computational backends by JohannesMessner · Pull Request #941 · docarray/docarray · GitHub

/ docarray Public

refactor(v2): computational backends - #941

Merged
JohannesMessner merged 28 commits into
feat-rewrite-v2from
refactor-comp-backends
Dec 16, 2022
ConversationCommits (28)ChecksFiles changed
Merged

refactor(v2): computational backends#941
JohannesMessner merged 28 commits into
feat-rewrite-v2from
refactor-comp-backends

Conversation

JohannesMessner commented Dec 14, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Goals:

This introduces "computational backends" for organizing and grouping functionality that is framework specific, e.g. numpy or torch

JohannesMessner and others added 21 commits November 29, 2022 11:13
refactor: make abstract tensor parametrization modular
1addc11 
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
feat: add type for torch embedding
b0b8497 
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
feat: embedding type for ndarray
68f3914 
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
fix: fix general embedding type
953b690 
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
test: update tests
766f6b9 
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
Merge remote-tracking branch 'origin/feat-rewrite-v2' into feat-rewri…
9dface7 
…te-v2
Merge remote-tracking branch 'origin/feat-rewrite-v2' into feat-rewri…
ed328e8 
…te-v2

# Conflicts:
#	docarray/typing/__init__.py
#	docarray/typing/tensor/__init__.py
#	docarray/typing/tensor/abstract_tensor.py
#	docarray/typing/tensor/embedding.py
#	tests/integrations/typing/test_torch_tensor.py
feat: find function
cd7087b 
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
feat: batched query input
9e950e1 
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
fix: fix metrics and add tests for them
e3d26e6 
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
test: add tests for find
1ed7d93 
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
test: add test for topk
0f7068f 
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
feat: add batched find
d5c9ef9 
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
test: add more tests
11cb7f2 
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
docs: improve docstrings
ba56987 
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
docs: improve docstrings
840ef79 
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
fix: mypy and some comments
6e48cdb 
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
Merge branch 'feat-rewrite-v2' into feat-find
8dc40d5
refactor: add computational backends
f28cf79 
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
refactor: use comp backends in find function
0177836 
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
Merge branch 'feat-rewrite-v2' into refactor-comp-backends
fe85baa
refactor: clean up file structure
3921ac8 
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
github-actions Bot added size/xl and removed size/l labels Dec 14, 2022

github-actions Bot commented Dec 14, 2022

Copy link
Copy Markdown

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

JohannesMessner marked this pull request as ready for review December 14, 2022 14:37
JohannesMessner self-assigned this Dec 14, 2022
JohannesMessner changed the title refactor: computational backends refactor(v2): computational backends Dec 14, 2022
JohannesMessner marked this pull request as draft December 14, 2022 14:43
fix: some typing issues
4597115 
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
Merge branch 'feat-rewrite-v2' into refactor-comp-backends
d61b765 
Signed-off-by: Johannes Messner <44071807+JohannesMessner@users.noreply.github.com>
samsja reviewed Dec 14, 2022
View reviewed changes
Comment thread docarray/computation/abstract_comp_backend.py Outdated

github-actions Bot commented Dec 14, 2022

Copy link
Copy Markdown

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

fix: reduce mypy errors
4a6e1b3 
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
fix: mypy
650376f 
Signed-off-by: Johannes Messner <messnerjo@gmail.com>

github-actions Bot commented Dec 15, 2022

Copy link
Copy Markdown

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

fix: mypy
73a4358 
Signed-off-by: Johannes Messner <messnerjo@gmail.com>

github-actions Bot commented Dec 15, 2022

Copy link
Copy Markdown

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

samsja reviewed Dec 16, 2022
View reviewed changes
Comment thread docarray/typing/abstract_type.py Outdated
JohannesMessner marked this pull request as ready for review December 16, 2022 10:39
refactor: remove is_tensor flag
4b50d0f 
Signed-off-by: Johannes Messner <messnerjo@gmail.com>

github-actions Bot commented Dec 16, 2022

Copy link
Copy Markdown

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions Bot commented Dec 16, 2022

Copy link
Copy Markdown

📝 Docs are deployed on https://ft-refactor-comp-backends--jina-docs.netlify.app 🎉

samsja approved these changes Dec 16, 2022
View reviewed changes
Comment thread docarray/computation/abstract_comp_backend.py Outdated
JohannesMessner merged commit 20f634d into feat-rewrite-v2 Dec 16, 2022
JohannesMessner deleted the refactor-comp-backends branch December 16, 2022 12:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

samsja samsja approved these changes

Assignees

JohannesMessner

Labels

area/core area/testing area/typing size/xl

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL