bake: pass variables explicitly to buildx - #277
Draft
crazy-max wants to merge 4 commits into
Draft
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
This comment was marked as spam.
Disable Bake environment variable lookup so workflow and runner environment values do not implicitly override Bake variables. Forward only GITHUB_ and RUNNER_ prefixed values as explicit Bake vars, then pass the caller vars input through docker/bake-action. Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
At least 1 approving review is required to merge this pull request.
Assignees
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
needs #248 (see last commit)
This changes the Bake reusable workflow to pass caller-provided Bake variables through docker/bake-action as explicit vars instead of exporting them into the step environment. Bake environment variable lookup is disabled so workflow and runner env values do not accidentally override Bake variables, while GITHUB_ and RUNNER_ prefixed values are still forwarded explicitly for workflows that intentionally declare them.