Repository navigation
Fix tar with symlink - #1218
Merged
KostyaSha merged 2 commits intoJul 12, 2019
Merged
Fix tar with symlink#1218KostyaSha merged 2 commits into
KostyaSha merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This remove the duplicated code to handle executable file and copy of the file content into the archive. It will also allow to fix the symlink without duplicating the fix in 3 places. Related to issue docker-java#532
Symbolic link should be archived as is, same as what native docker client does. Closes docker-java#532
Copy link
Copy Markdown
Contributor
Author
|
Could you not squash the commits when merging this PR to preserve detailed commit messages in the git history. Thanks for all the swift reviews! |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
I'm not squashing when commits are clear and not numerious fixups ) |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #532
This change is