Missing 'until' params - #1429
Open
mortharia wants to merge 2 commits into
Open
Missing 'until' params #1429mortharia wants to merge 2 commits into
mortharia wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@mortharia sorry for letting it stale. Could you please change the test to not use Thread.sleeps? Thank you! |
Sorry, something went wrong.
eddumelendez
reviewed
Mar 8, 2023
| assertThat(container.getId(), not(is(emptyString()))); | ||
|
|
||
| dockerRule.getClient().startContainerCmd(container.getId()).exec(); | ||
| Thread.sleep(5000); |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Use Awaitility instead
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
At least 1 approving review is required to merge this pull request.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #1427
This change is