Repository navigation
Add test case for build with a large subdirectory - #1441
Closed
swiedenfeld wants to merge 2 commits into
Closed
swiedenfeld wants to merge 2 commits into
swiedenfeld wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
I found the lines in .dockerignore were wrong. The largesubdir has not been excluded, I fixed that. Scan finishes in just something under 3 seconds repeatedly. I am a bit disappointed, because this does not match my observation in #1409. I am going to revisit the original case. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a test case for a build Dockerfile scan, when the context root contains a large directory tree.
The context root directory contains one subdirectory with 140 subdirectories and 70 files each (9,800 files in total).
The .dockerignore file ignores the subdirectory with except of one file.
The test assertions require the build scan to finish in under 3 seconds and add 3 files (Dockerfile, .dockerignore and the excepted file).
This test currently fails. The test fixture should approximate the situation described in #1409. I restricted the test fixture to 9,800 files, because 70,000 files have a very negative impact on project build and test executions.
Please give some feedback on the given test assertions. I chose 3 seconds to finish randomly. The build scan of my local Docker CLI finishes in under 1 second. I added 2 seconds because I assume there is some overhead?