FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Accelerate build context directory file walk by swiedenfeld · Pull Request #1442 · docker-java/docker-java · GitHub

Repository navigation

Accelerate build context directory file walk - #1442

Closed
swiedenfeld wants to merge 5 commits into
docker-java:masterfrom
swiedenfeld:improve-filewalk-performance
Closed

swiedenfeld wants to merge 5 commits into
docker-java:masterfrom
swiedenfeld:improve-filewalk-performance

Conversation

Copy link
Copy Markdown
Contributor

This PR addresses the performance issue described in #1409.

#1412 has partially improved performance by memoizing frequently reused ignore patterns.
These commits now improve performance on my Windows 10 machine further by:

  • Use Java NIO Files.walk to efficiently walk the build context directory. It visits files and subdirectories in parallel and filters any items efficiently ignored
  • Use java.nio.file.Path#toUri instead of java.io.File#toUri, because it executes faster

With #1412 and these code changes, build context scans in my unit test setup (see #1412) on my Windows 10 machine now pass in about 6 seconds, while they previously used to take around 27 seconds.

java.nio.file.Path#toUri executes faster compared to java.io.File#toUri

Copy link
Copy Markdown
Contributor Author

@bsideup I could use some input on this :)

Copy link
Copy Markdown
Contributor Author

ping (before this goes stale)

stale Bot commented Sep 20, 2020

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

bsideup commented Sep 27, 2020

Copy link
Copy Markdown
Member

@swiedenfeld sorry for letting it stale, I will try to find time and have a look at it soon!

Copy link
Copy Markdown
Contributor Author

How can we proceed with this?

swiedenfeld deleted the improve-filewalk-performance branch July 14, 2021 19:32

Copy link
Copy Markdown

I wish this still was a thing

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL