Repository navigation
Add npipe as a valid mount type - #1788
bsideup merged 1 commit into
Conversation
Sorry, something went wrong.
|
Hi @aroskuski, Could you please make the change focused on adding NPIPE mount type (easy to accept), and extract the Windows testing into a separate PR (needs a discussion)? Thank you! |
Sorry, something went wrong.
|
Alright @bsideup, I've split the unit test stuff out into #1804 so that it can be dealt with separately. I'm not super attached to those changes, it just seemed like a useful thing to do since I was testing the feature out on Windows for obvious reasons. |
Sorry, something went wrong.
|
@aroskuski thank you! I think the change is valid, I was just working on preparing a release and wanted to include your change, but wasn't ready to review that test-related change 👍 Will have a look after the release 👍 Thank you! |
Sorry, something went wrong.
Version 1.40 of the API (or at least I think it was that version, had to manually search through versions of the doc) added npipe as a valid mount type. This is necessary for certain cases, like mounting the default docker pipe on Windows inside a container.
I've manually tested that this change works, but automated testing has proven a bit of a challenge. It's kind of too trivial to write a meaningful unit test for (though I did go through and made sure the all the existing tests passed, on Windows, even), and there doesn't appear to be an obvious way to add an integration test for a Windows-only feature.