Repository navigation
load testing resources from classpath path - #1823
Merged
eddumelendez merged 5 commits intoMar 9, 2023
Merged
eddumelendez merged 5 commits into
eddumelendez merged 5 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Hi @mwiede! Sorry, it looks like tests were unstable. Could you please with with master (just fixed it there). Thank you! |
Sorry, something went wrong.
Copy link
Copy Markdown
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@eddumelendez could you please consider reopen and merge this? Thanks |
Sorry, something went wrong.
eddumelendez
reviewed
Mar 8, 2023
Comment thread
docker-java/src/test/java/com/github/dockerjava/cmd/CopyArchiveToContainerCmdIT.java
Resolved
eddumelendez
approved these changes
Mar 9, 2023
Copy link
Copy Markdown
Member
|
Thanks for your contribution, @mwiede ! and sorry about the delay. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was importing the test-jar of com.github.docker-java:docker-java to reuse the test classes. I found the problem, that this was not possible until the files used in testing are loading from classpath instead of source path.