Repository navigation
Fix #1258: Support copyUIDGID option in CopyArchiveToContainerCmd - #1963
Merged
eddumelendez merged 3 commits intoOct 17, 2022
Merged
eddumelendez merged 3 commits into
eddumelendez merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…inerCmd Signed-off-by: kwall <kwall@apache.org>
Copy link
Copy Markdown
Contributor
Author
|
I'm a Podman user rather than Docker. I'm hoping my changes will allow the new IT to pass against Docker too. Thank you. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
would a reviewer be able to take a look at this PR please? |
Sorry, something went wrong.
eddumelendez
approved these changes
Oct 10, 2022
Copy link
Copy Markdown
Member
|
thanks for your contribution @k-wall! This is now part of master branch |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes maintain the existing semantics (i.e. copyUIDGID = false) unless the caller sets the new option true.
Supporting integration test added.
Signed-off-by: kwall kwall@apache.org