Repository navigation
Add Name to ContainerNetworkConfig - #2052
Merged
eddumelendez merged 2 commits intoFeb 5, 2023
Merged
eddumelendez merged 2 commits into
eddumelendez merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Signed-off-by: Harald Albers <github@albersweb.de>
eddumelendez
approved these changes
Feb 3, 2023
eddumelendez
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
First appearance was on v1.22 https://docs.docker.com/engine/api/v1.22/
Sorry, something went wrong.
Comment thread
docker-java-api/src/main/java/com/github/dockerjava/api/model/Network.java
Resolved
Co-authored-by: Eddú Meléndez Gonzales <eddu.melendez@gmail.com>
Copy link
Copy Markdown
Member
|
Thanks for your contribution, @albers! This is now merged in master branch and it will be part of the next release. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Thank you @eddumelendez. I'm looking forward to the next release. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a use case where this property would be very helpful:
In a Quarkus integration test, I have to find a container in a temporary network based on its name.
With the current codebase, I have to inspect each container in the network in order to find the matching container.
Having the container name available in ContainerNetworkConfig would simplify the search.
The Name property appears first in the v1.30 Docker api docs.