FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Support TLS configuration from docker context by piotrwielgolaski-tomtom · Pull Request #2105 · docker-java/docker-java · GitHub

  1. docker-java
  2. docker-java

Repository navigation

Support TLS configuration from docker context - #2105

Merged
eddumelendez merged 2 commits into
docker-java:mainfrom
piotrwielgolaski-tomtom:faeture/tls_settings_from_context
May 29, 2023
ConversationCommits (2)ChecksFiles changed
Merged

Support TLS configuration from docker context#2105
eddumelendez merged 2 commits into
docker-java:mainfrom
piotrwielgolaski-tomtom:faeture/tls_settings_from_context

Conversation

piotrwielgolaski-tomtom commented Apr 9, 2023

Copy link
Copy Markdown
Contributor

It is small extension to support TLS part of configuration from docker context

Continuation of issue #1946

piotrwielgolaski-tomtom requested a review from a team as a code owner April 9, 2023 17:08
piotrwielgolaski-tomtom mentioned this pull request Apr 13, 2023
Open

piotrwielgolaski-tomtom commented Apr 19, 2023

Copy link
Copy Markdown
Contributor Author

@eddumelendez as you reviewed original PR #2036 maybe you could take a look at this one as well?

piotrwielgolaski-tomtom commented May 7, 2023

Copy link
Copy Markdown
Contributor Author

kindly reminder, what can I do to make it part of main?

eddumelendez self-assigned this May 7, 2023

piotrwielgolaski-tomtom commented May 17, 2023

Copy link
Copy Markdown
Contributor Author

@eddumelendez any change you can take a look at it?
I would love to make test containeraware of docker context

eddumelendez commented May 25, 2023

Copy link
Copy Markdown
Member

@piotrwielgolaski-tomtom sorry for the delay, can you please amend the last commit in order to perform a force push, please? IDK the reason why CI didn't execute.

piotrwielgolaski-tomtom commented May 25, 2023

Copy link
Copy Markdown
Contributor Author

Sorry what should I change? Only rebase or should I change something? I don't send check, so it is hard to understand what is wrong.

eddumelendez commented May 25, 2023

Copy link
Copy Markdown
Member

Running git commit --amend should work and then git push -f

Support TLS configuration from docker context
4e56bd2 
supporting TLS in case remote docker host is used

piotrwielgolaski-tomtom commented May 25, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I added extra description in commit and push it again, I hope it will helps.
Let me know if I can do anything to push it forward.

eddumelendez commented May 25, 2023

Copy link
Copy Markdown
Member

I'm able to approve and now checks are running. Thanks!

eddumelendez merged commit dddd439 into docker-java:main May 29, 2023
eddumelendez added this to the next milestone May 29, 2023

eddumelendez commented May 29, 2023

Copy link
Copy Markdown
Member

Thanks for your contribution, @piotrwielgolaski-tomtom ! and sorry for the delay. This will be available in the next version

piotrwielgolaski-tomtom deleted the faeture/tls_settings_from_context branch June 3, 2023 04:53
piotrwielgolaski-tomtom mentioned this pull request Jun 8, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

eddumelendez

Labels

type/enhancement

Projects

None yet

Milestone

3.3.2

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL