FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(2127): handle repoNames with tags by setchy · Pull Request #2128 · docker-java/docker-java · GitHub

/ docker-java Public

fix(2127): handle repoNames with tags - #2128

Merged
eddumelendez merged 2 commits into
docker-java:mainfrom
setchy:feature/2127-support-tag-and-digest-2
Jun 19, 2023
ConversationCommits (2)ChecksFiles changed
Merged

fix(2127): handle repoNames with tags#2128
eddumelendez merged 2 commits into
docker-java:mainfrom
setchy:feature/2127-support-tag-and-digest-2

Conversation

setchy commented Jun 2, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

This update improved the handling for resolveRepositoryName when the image statement includes a registry and tags.

Current behavior will throw the error as reported in the issue

Resolves: #2127 - confirmed by @leomao10

setchy requested a review from a team as a code owner June 2, 2023 20:55

setchy commented Jun 19, 2023

Copy link
Copy Markdown
Contributor Author

@eddumelendez - could you kindly review this PR 🙏

setchy mentioned this pull request Jun 19, 2023
Closed
eddumelendez approved these changes Jun 19, 2023
View reviewed changes

eddumelendez left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

eddumelendez merged commit dd0de7c into docker-java:main Jun 19, 2023

eddumelendez commented Jun 19, 2023

Copy link
Copy Markdown
Member

Thanks for your contribution, @setchy !

eddumelendez added this to the next milestone Jun 19, 2023

setchy commented Jun 19, 2023

Copy link
Copy Markdown
Contributor Author

Thanks @eddumelendez for the speedy review. Greatly appreciated 🙏

setchy commented Jun 20, 2023

Copy link
Copy Markdown
Contributor Author

@eddumelendez - to help with my internal sprint planning and stakeholder mgmt, can you educate my about the release cadence for docker-java

eddumelendez commented Jun 20, 2023

Copy link
Copy Markdown
Member

There is no release schedule but as soon there are many good improvement features we will do the release. Indeed, I'm just waiting for other PR to perform it.

setchy deleted the feature/2127-support-tag-and-digest-2 branch July 5, 2023 16:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

eddumelendez eddumelendez approved these changes

Assignees

No one assigned

Labels

type/enhancement

Projects

None yet

Milestone

3.3.2

Development

Successfully merging this pull request may close these issues.

Parse Docker images of <name>:<tag>@sha256:<hash> format

2 participants

Back | FazBrowse Home | New Git URL