FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fixing flaky test `ListContainersCmdIT.testStatusFilter` by dmmax · Pull Request #2188 · docker-java/docker-java · GitHub

Repository navigation

Fixing flaky test ListContainersCmdIT.testStatusFilter - #2188

Merged
eddumelendez merged 3 commits into
docker-java:mainfrom
dmmax:fix_flaky_test_list_containers_cmd
Oct 26, 2023
Merged

eddumelendez merged 3 commits into
docker-java:mainfrom
dmmax:fix_flaky_test_list_containers_cmd

Conversation

dmmax commented Aug 21, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Changes

  • Decouple the big test (testStatusFilter ) into 4 smaller tests for checking each status independently (created, running, paused, exited)
  • Add waitContainer - the same way as it is done in Improve assertions #2189

dmmax requested a review from a team as a code owner August 21, 2023 14:34

dmmax commented Aug 24, 2023

Copy link
Copy Markdown
Contributor Author

Hi @eddumelendez

Can you review the current or #2189 PR to unblock #2186 and other PRs?

eddumelendez added this to the next milestone Oct 26, 2023
eddumelendez merged commit ede20db into docker-java:main Oct 26, 2023

Copy link
Copy Markdown
Member

@dmmax sorry for the delay! and thanks for your contribution!

eddumelendez mentioned this pull request Oct 26, 2023
dmmax deleted the fix_flaky_test_list_containers_cmd branch October 29, 2023 16:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL