FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add Network create attribute by juanmolle · Pull Request #2344 · docker-java/docker-java · GitHub

Add Network create attribute - #2344

Merged
eddumelendez merged 3 commits into
docker-java:mainfrom
juanmolle:add_network_create_attribute
Jul 9, 2024
Merged

Add Network create attribute#2344
eddumelendez merged 3 commits into
docker-java:mainfrom
juanmolle:add_network_create_attribute

Conversation

juanmolle commented Jun 24, 2024
edited
Loading

Copy link
Copy Markdown
Contributor

This PR Parse Create attribute from Network Object

Related: #2343

juanmolle requested a review from a team as a code owner June 24, 2024 16:03

Copy link
Copy Markdown
Contributor Author

/assign @eddumelendez

Copy link
Copy Markdown
Member

Hi, thanks for the PR. I don't see the created attribute in Network create operation https://docs.docker.com/engine/api/v1.45/#tag/Network/operation/NetworkCreate

juanmolle commented Jun 24, 2024
edited
Loading

Copy link
Copy Markdown
Contributor Author

Thanks for your quick review. Then I guess it is only valido for inspect. in that case, should I create a new object for inspectNetworkResponse?, to just add this attribute to it?

https://docs.docker.com/engine/api/v1.45/#tag/Network/operation/NetworkInspect

Copy link
Copy Markdown
Member

Oh ok, it belongs to the inspect network response. There is similar things for containers so let's keep it as it. It should be reviewed in the future.

Copy link
Copy Markdown
Contributor Author

Checking createNetwork return a CreateNetworkResponse, it does not contains createTime. Network Object is used to return Network information, it contains the creation time

Copy link
Copy Markdown
Contributor Author

Some unrelated test are failing, not sure why.

eddumelendez added this to the next milestone Jul 9, 2024
eddumelendez merged commit 242c76a into docker-java:main Jul 9, 2024

Copy link
Copy Markdown
Member

Thanks for your contribution, @juanmolle !

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL