Fix RestartPolicy.noRestart() so it can disable restart on existing containers - #2674
Open
jcongithub wants to merge 1 commit into
Open
Fix RestartPolicy.noRestart() so it can disable restart on existing containers#2674jcongithub wants to merge 1 commit into
jcongithub wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
…ontainers
noRestart() returned a policy with an empty Name (""), which the Docker Engine
update endpoint ignores: it only applies RestartPolicy when Name != "". As a
result an existing container could not be switched from always/on-failure back
to no-restart via updateContainerCmd.
Return Name "no" instead - a valid "none" policy (RestartPolicy.IsNone() is true
for both "" and "no") that the daemon actually applies. Update
RestartPolicySerializingTest to match; this also matches what modern Docker sends
for `docker run --restart no`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
noRestart() returned a policy with an empty Name (""), which the Docker Engine update endpoint ignores: it only applies RestartPolicy when Name != "". As a result an existing container could not be switched from always/on-failure back to no-restart via updateContainerCmd.
Return Name "no" instead - a valid "none" policy (RestartPolicy.IsNone() is true for both "" and "no") that the daemon actually applies. Update RestartPolicySerializingTest to match; this also matches what modern Docker sends for docker run --restart no.