FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix it by KostyaSha · Pull Request #620 · docker-java/docker-java · GitHub

Repository navigation

Fix it - #620

Closed
KostyaSha wants to merge 18 commits into
masterfrom
fixIT
Closed

Fix it#620
KostyaSha wants to merge 18 commits into
masterfrom
fixIT

Conversation

KostyaSha commented Jun 29, 2016 •
edited
Loading

Copy link
Copy Markdown
Member

trying fix ITs with mass changes
closes #491


This change is

KostyaSha added 17 commits June 20, 2016 14:55
com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException: Unrecognized field "username" (class com.github.dockerjava.api.model.AuthConfig), not marked as ignorable (0 known properties: ])
 at [Source: {
  "username": "jdoe",
  "password": "secret",
  "email": "jdoe@acme.com"
}

try {
InputStream inputStream = new WrappedResponseInputStream(response);
try (InputStream inputStream = new WrappedResponseInputStream(response)) {

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@marcuslinke resource leak fix

Copy link
Copy Markdown
Member Author

@marcuslinke i tried upgrade to jersey version that contains fix for your issue, but got

deleteDockerContainerImage(com.github.dockerjava.netty.exec.AttachContainerCmdExecTest)  Time elapsed: 0.326 sec  <<< FAILURE!
javax.ws.rs.ProcessingException: java.lang.IllegalStateException: Connection pool shut down
Caused by: java.lang.IllegalStateException: Connection pool shut down

Have you seen this error before?

This was referenced Jul 4, 2016

Copy link
Copy Markdown
Contributor

@KostyaSha No, haven't seen this before. Will try to reproduce locally...

KostyaSha commented Jul 4, 2016 •
edited
Loading

Copy link
Copy Markdown
Member Author

@marcuslinke i see a lot of different fails (jersey, hijack, connection pool), trying to split everything to small portions now.

KostyaSha commented Jul 4, 2016 •
edited
Loading

Copy link
Copy Markdown
Member Author

$ export DOCKER_HOST="unix:///var/run/docker.sock"
$ export DOCKER_VERSION="1.11.2-0~trusty"

Tests run: 358, Failures: 7, Errors: 0, Skipped: 57, Time elapsed: 480.982 sec <<< FAILURE! - in TestSuite
(com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest)  Time elapsed: 0.378 sec  <<< FAILURE!
javax.ws.rs.ProcessingException: Error closing message content input stream.
    at com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest.assertFileCopied(CopyArchiveToContainerCmdImplTest.java:83)
    at com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest.copyFileToContainer(CopyArchiveToContainerCmdImplTest.java:57)
Caused by: java.io.IOException: Bad file descriptor at Socket[addr=0.0.0.0/0.0.0.0,port=0,localport=0][fd=java.io.FileDescriptor@3284854a; file=/run/docker.sock; connected=false; bound=false]
    at com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest.assertFileCopied(CopyArchiveToContainerCmdImplTest.java:83)
    at com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest.copyFileToContainer(CopyArchiveToContainerCmdImplTest.java:57)
Caused by: org.newsclub.net.unix.AFUNIXSocketException: Bad file descriptor
    at com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest.assertFileCopied(CopyArchiveToContainerCmdImplTest.java:83)
    at com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest.copyFileToContainer(CopyArchiveToContainerCmdImplTest.java:57)
(com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest)  Time elapsed: 0.376 sec  <<< FAILURE!
javax.ws.rs.ProcessingException: Error closing message content input stream.
    at com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest.assertFileCopied(CopyArchiveToContainerCmdImplTest.java:83)
    at com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest.copyStreamToContainer(CopyArchiveToContainerCmdImplTest.java:66)
Caused by: java.io.IOException: Bad file descriptor at Socket[addr=0.0.0.0/0.0.0.0,port=0,localport=0][fd=java.io.FileDescriptor@7bf6d56d; file=/run/docker.sock; connected=false; bound=false]
    at com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest.assertFileCopied(CopyArchiveToContainerCmdImplTest.java:83)
    at com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest.copyStreamToContainer(CopyArchiveToContainerCmdImplTest.java:66)
Caused by: org.newsclub.net.unix.AFUNIXSocketException: Bad file descriptor
    at com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest.assertFileCopied(CopyArchiveToContainerCmdImplTest.java:83)
    at com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest.copyStreamToContainer(CopyArchiveToContainerCmdImplTest.java:66)
(com.github.dockerjava.core.command.StatsCmdImplTest)  Time elapsed: 4.166 sec  <<< FAILURE!
javax.ws.rs.ProcessingException: Error closing message content input stream.
    at com.github.dockerjava.core.command.StatsCmdImplTest.testStatsStreaming(StatsCmdImplTest.java:73)
Caused by: java.io.IOException: Bad file descriptor at Socket[addr=0.0.0.0/0.0.0.0,port=0,localport=0][fd=java.io.FileDescriptor@7f51b0f0; file=/run/docker.sock; connected=false; bound=false]
    at com.github.dockerjava.core.command.StatsCmdImplTest.testStatsStreaming(StatsCmdImplTest.java:73)
Caused by: org.newsclub.net.unix.AFUNIXSocketException: Bad file descriptor
    at com.github.dockerjava.core.command.StatsCmdImplTest.testStatsStreaming(StatsCmdImplTest.java:73)
(com.github.dockerjava.core.command.EventsCmdImplTest)  Time elapsed: 19.434 sec  <<< FAILURE!
javax.ws.rs.ProcessingException: Error closing message content input stream.
    at com.github.dockerjava.core.command.EventsCmdImplTest.testEventStreaming1(EventsCmdImplTest.java:87)
Caused by: java.io.IOException: Bad file descriptor at Socket[addr=0.0.0.0/0.0.0.0,port=0,localport=0][fd=java.io.FileDescriptor@19733990; file=/run/docker.sock; connected=false; bound=false]
    at com.github.dockerjava.core.command.EventsCmdImplTest.testEventStreaming1(EventsCmdImplTest.java:87)
Caused by: org.newsclub.net.unix.AFUNIXSocketException: Bad file descriptor
    at com.github.dockerjava.core.command.EventsCmdImplTest.testEventStreaming1(EventsCmdImplTest.java:87)
(com.github.dockerjava.core.command.EventsCmdImplTest)  Time elapsed: 20.436 sec  <<< FAILURE!
javax.ws.rs.ProcessingException: Error closing message content input stream.
    at com.github.dockerjava.core.command.EventsCmdImplTest.testEventStreaming2(EventsCmdImplTest.java:105)
Caused by: java.io.IOException: Bad file descriptor at Socket[addr=0.0.0.0/0.0.0.0,port=0,localport=0][fd=java.io.FileDescriptor@55a266b2; file=/run/docker.sock; connected=false; bound=false]
    at com.github.dockerjava.core.command.EventsCmdImplTest.testEventStreaming2(EventsCmdImplTest.java:105)
Caused by: org.newsclub.net.unix.AFUNIXSocketException: Bad file descriptor
    at com.github.dockerjava.core.command.EventsCmdImplTest.testEventStreaming2(EventsCmdImplTest.java:105)
(com.github.dockerjava.core.command.EventsCmdImplTest)  Time elapsed: 20.158 sec  <<< FAILURE!
javax.ws.rs.ProcessingException: Error closing message content input stream.
    at com.github.dockerjava.core.command.EventsCmdImplTest.testEventStreamingWithFilter(EventsCmdImplTest.java:121)
Caused by: java.io.IOException: Bad file descriptor at Socket[addr=0.0.0.0/0.0.0.0,port=0,localport=0][fd=java.io.FileDescriptor@79f7ec4f; file=/run/docker.sock; connected=false; bound=false]
    at com.github.dockerjava.core.command.EventsCmdImplTest.testEventStreamingWithFilter(EventsCmdImplTest.java:121)
Caused by: org.newsclub.net.unix.AFUNIXSocketException: Bad file descriptor
    at com.github.dockerjava.core.command.EventsCmdImplTest.testEventStreamingWithFilter(EventsCmdImplTest.java:121)
deleteDockerContainerImage(com.github.dockerjava.netty.exec.AttachContainerCmdExecTest)  Time elapsed: 0.338 sec  <<< FAILURE!
javax.ws.rs.ProcessingException: java.lang.IllegalStateException: Connection pool shut down
Caused by: java.lang.IllegalStateException: Connection pool shut down
Results :
Failed tests: 
com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest.(com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest)
  Run 1: PASS
  Run 2: CopyArchiveToContainerCmdImplTest.copyFileToContainer:57->assertFileCopied:83 » Processing
  Run 3: PASS
  Run 4: CopyArchiveToContainerCmdImplTest.copyStreamToContainer:66->assertFileCopied:83 » Processing
  Run 5: PASS
com.github.dockerjava.core.command.EventsCmdImplTest.(com.github.dockerjava.core.command.EventsCmdImplTest)
  Run 1: PASS
  Run 2: EventsCmdImplTest.testEventStreaming1:87 » Processing Error closing message co...
  Run 3: EventsCmdImplTest.testEventStreaming2:105 » Processing Error closing message c...
  Run 4: EventsCmdImplTest.testEventStreamingWithFilter:121 » Processing Error closing ...
  StatsCmdImplTest.testStatsStreaming:73 » Processing Error closing message cont...
  AttachContainerCmdExecTest.deleteDockerContainerImage » Processing java.lang.I...
Tests run: 295, Failures: 4, Errors: 0, Skipped: 1

Copy link
Copy Markdown
Member Author

$ export DOCKER_HOST="tcp://127.0.0.1:2375"
$ export DOCKER_VERSION="1.11.2-0~trusty"

Tests run: 358, Failures: 2, Errors: 0, Skipped: 57, Time elapsed: 480.484 sec <<< FAILURE! - in TestSuite
(com.github.dockerjava.core.command.FrameReaderITest)  Time elapsed: 0.808 sec  <<< FAILURE!
java.lang.IllegalStateException: Connection pool shut down
deleteDockerContainerImage(com.github.dockerjava.netty.exec.AttachContainerCmdExecTest)  Time elapsed: 0.326 sec  <<< FAILURE!
javax.ws.rs.ProcessingException: java.lang.IllegalStateException: Connection pool shut down
Caused by: java.lang.IllegalStateException: Connection pool shut down
Results :
Failed tests: 
com.github.dockerjava.core.command.FrameReaderITest.(com.github.dockerjava.core.command.FrameReaderITest)
  Run 1: PASS
  Run 2: FrameReaderITest.canLogInOneThreadAndExecuteCommandsInAnother » IllegalState C...
  AttachContainerCmdExecTest.deleteDockerContainerImage » Processing java.lang.I...
Tests run: 301, Failures: 2, Errors: 0, Skipped: 1

Copy link
Copy Markdown
Member Author

One IT now green https://travis-ci.org/docker-java/docker-java/jobs/143116581 ! perfect

Copy link
Copy Markdown
Member Author

And unix may fail because i switched deps...

Copy link
Copy Markdown
Member Author

@marcuslinke don't worry i will make clean PR, in process..

KostyaSha mentioned this pull request Jul 7, 2016

Copy link
Copy Markdown
Member Author

Everything beside junix socket update was merged. closing.

KostyaSha closed this Jul 12, 2016
KostyaSha deleted the fixIT branch September 28, 2016 23:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update jersey with the fix

2 participants


Back | FazBrowse Home | New Git URL