FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix for #643 by tejksat · Pull Request #648 · docker-java/docker-java · GitHub

  1. docker-java
  2. docker-java

Repository navigation

Fix for #643 - #648

Merged
KostyaSha merged 2 commits into
docker-java:masterfrom
tejksat:fixDockerignoreRulesProcessing
Aug 1, 2016
ConversationCommits (2)ChecksFiles changed
Merged

Fix for #643#648
KostyaSha merged 2 commits into
docker-java:masterfrom
tejksat:fixDockerignoreRulesProcessing

Conversation

tejksat commented Jul 29, 2016 •
edited by KostyaSha
Loading

Copy link
Copy Markdown
Contributor

Fix for #643
.dockerignore rules handling refactored. A rule is translated to a regexp pattern and then a path is checked against it.

This change is

Fix for docker-java#643
1ecc16f 
.dockerignore rules handling refactored. A rule is translated to a regexp pattern and then a path is checked against it.
tejksat mentioned this pull request Jul 29, 2016
Closed

KostyaSha commented Jul 29, 2016

Copy link
Copy Markdown
Member

Looks crazy :)

tejksat commented Jul 29, 2016

Copy link
Copy Markdown
Contributor Author

@KostyaSha what exactly?)

KostyaSha commented Jul 29, 2016

Copy link
Copy Markdown
Member

Too much changes, will try read again bit later.

tejksat commented Jul 30, 2016

Copy link
Copy Markdown
Contributor Author

@KostyaSha yeah, true. It's better to read match() method as a new one. It've been changed heavy.

Fix for docker-java#643
8228314 
Failing tests on Windows fixed: Windows file separator escaped.

KostyaSha commented Aug 1, 2016

Copy link
Copy Markdown
Member

If something will fail, then it pure tests issue. Thanks for contribution!

KostyaSha merged commit b1ed66b into docker-java:master Aug 1, 2016

KostyaSha commented Aug 1, 2016

Copy link
Copy Markdown
Member

Btw, would suggest look into docker-cli code and pick their algos :)

KostyaSha added this to the 3.0.1 milestone Aug 1, 2016

KostyaSha commented Aug 1, 2016

Copy link
Copy Markdown
Member

Checkstyle failed GoLangFileMatch length...

tejksat commented Aug 2, 2016

Copy link
Copy Markdown
Contributor Author

@KostyaSha I will refactor and PR soon.

tejksat commented Aug 2, 2016

Copy link
Copy Markdown
Contributor Author

Thanks for the good suggestion! I've almost guessed it right (https://github.com/docker/docker/blob/40044cb18fd4ff0ed13d8cdd41ec4dcecdac0703/pkg/fileutils/fileutils.go#L132) :)

KostyaSha commented Aug 2, 2016

Copy link
Copy Markdown
Member

And you can pick their test cases ;)

panuse pushed a commit to TuKangTech/docker-java that referenced this pull request Aug 20, 2017
Fix for docker-java#643 (docker-java#648)
721cb94 
* Fix for docker-java#643

.dockerignore rules handling refactored. A rule is translated to a regexp pattern and then a path is checked against it.

* Fix for docker-java#643

Failing tests on Windows fixed: Windows file separator escaped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

type/enhancement

Projects

None yet

Milestone

3.0.1

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL