FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

WIP load image refactor by KostyaSha · Pull Request #664 · docker-java/docker-java · GitHub

  1. docker-java
  2. docker-java

Repository navigation

WIP load image refactor - #664

Closed
KostyaSha wants to merge 1 commit into
docker-java:masterfrom
KostyaSha:reworkLoadImageClean
ConversationCommits (1)ChecksFiles changed
Closed

WIP load image refactor #664
KostyaSha wants to merge 1 commit into
docker-java:masterfrom
KostyaSha:reworkLoadImageClean

Conversation

KostyaSha commented Aug 14, 2016 •
edited by marcuslinke
Loading

Copy link
Copy Markdown
Member

cc @leonsabr
atm on jersey impl infinitely waits something...

This change is

KostyaSha mentioned this pull request Aug 14, 2016
Merged

KostyaSha commented Aug 14, 2016

Copy link
Copy Markdown
Member Author

@leonsabr i think we can ignore crazy docker API that returns plain text only for "quiet" mode.
https://twitter.com/kostyasha/status/764897368017866752
So making async command with callback that will show upload progress.

leonsabr commented Aug 16, 2016

Copy link
Copy Markdown
Contributor

Docker introduced this response in 1.23 API. My dev environment was 1.22 that time. Should I review this PR?

KostyaSha commented Aug 16, 2016

Copy link
Copy Markdown
Member Author

@leonsabr maybe we should make separate loadImage cmd then?

KostyaSha commented Aug 16, 2016

Copy link
Copy Markdown
Member Author

@leonsabr the initial issue was in your test failing on 1.24 (docker 1.12) could you try?

KostyaSha mentioned this pull request Aug 17, 2016
Closed

KostyaSha commented Aug 17, 2016

Copy link
Copy Markdown
Member Author

Created separated issue.

KostyaSha commented Aug 19, 2016

Copy link
Copy Markdown
Member Author

Found bug in docker API

KostyaSha mentioned this pull request Aug 28, 2016
Merged
bsideup removed the API/<1.17 label Mar 16, 2020
bsideup closed this May 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL