ci: Remove VERSION from Dockerfile - #3711
Merged
polarathene merged 4 commits intoDec 19, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This line was meant to be dropped with the switch to using the `DMS_RELEASE` ENV.
Closed
Copy link
Copy Markdown
Member
I would mention the file removal. There may be custom stuff from users depending on that file 😆 |
Sorry, something went wrong.
georglauterbach
previously approved these changes
Dec 18, 2023
Copy link
Copy Markdown
Member
Author
Technically it was intended to be implicit as part of the changelog for 13.0.1, if it was handled then I don't think the changelog entry would have changed? I can add an explicit mention of the file being removed from the Dockerfile if you'd like?
That's a pretty neat utility! 😎 Kind of seeing a matryoshka hierarchy there: mailctl => setup.sh => setup 😆 |
Sorry, something went wrong.
polarathene
enabled auto-merge (squash)
December 19, 2023 01:55
georglauterbach
approved these changes
Dec 19, 2023
reneploetz
pushed a commit
to reneploetz/docker-mailserver
that referenced
this pull request
Dec 20, 2023
* ci: Remove `VERSION` from `Dockerfile` This line was meant to be dropped with the switch to using the `DMS_RELEASE` ENV.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This line was meant to be dropped with the switch to using the DMS_RELEASE ENV.
No changelog entry seems necessary?