FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Postfix: add `smtpd_data_restrictions = reject_unauth_pipelining` by georglauterbach · Pull Request #3744 · docker-mailserver/docker-mailserver · GitHub

/ docker-mailserver Public

Postfix: add smtpd_data_restrictions = reject_unauth_pipelining - #3744

Merged
georglauterbach merged 5 commits into
masterfrom
postfix/pipelining
Jan 4, 2024
ConversationCommits (5)ChecksFiles changed
Merged

Postfix: add smtpd_data_restrictions = reject_unauth_pipelining#3744
georglauterbach merged 5 commits into
masterfrom
postfix/pipelining

Conversation

georglauterbach commented Jan 3, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Description

See #3741

Fixes #3741

Type of change

  • Improvement (non-breaking change that does improve existing functionality)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added information about changes made in this PR to CHANGELOG.md

georglauterbach added service/postfix area/configuration (file) kind/update Update an existing feature, configuration file or the documentation labels Jan 3, 2024
georglauterbach added this to the v14.0.0 milestone Jan 3, 2024
georglauterbach self-assigned this Jan 3, 2024

georglauterbach commented Jan 3, 2024

Copy link
Copy Markdown
Member Author

Okay, tests fail as expected; wherever we use nc,

polarathene commented Jan 3, 2024

Copy link
Copy Markdown
Member

tests fail as expected; wherever we use nc

No worries, this change isn't a priority 👍

We could probably relax configuration for those affected tests as a workaround with postfix-main.cf, which should work.

polarathene reviewed Jan 3, 2024
View reviewed changes

polarathene left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This may work.

Comment thread target/postfix/main.cf Outdated
polarathene requested changes Jan 3, 2024
View reviewed changes
Comment thread target/amavis/postfix-amavis.cf

polarathene commented Jan 3, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Tests pass now. Just restore the Amavis config line + changelog entry and this should be good to go 🚀

There is an existing changelog line for the SMTP smuggling fix that is related to this change. Although we didn't try the adding trust in our previous attempt so it may not matter 🤷‍♂️ (the IPv6 concern would now also apply though)

georglauterbach added the meta/feature freeze On hold due to upcoming release process label Jan 4, 2024
casperklein previously approved these changes Jan 4, 2024
View reviewed changes
polarathene requested changes Jan 4, 2024
View reviewed changes
Comment thread CHANGELOG.md Outdated
polarathene mentioned this pull request Jan 4, 2024
Merged
4 tasks
georglauterbach merged commit bf69ef2 into master Jan 4, 2024
georglauterbach deleted the postfix/pipelining branch January 4, 2024 21:13
georglauterbach modified the milestones: v14.0.0, v13.2.0 Jan 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

polarathene polarathene approved these changes
casperklein casperklein left review comments

Assignees

georglauterbach

Labels

area/configuration (file) kind/update Update an existing feature, configuration file or the documentation meta/feature freeze On hold due to upcoming release process service/postfix

Projects

None yet

Milestone

v13.2.0

Development

Successfully merging this pull request may close these issues.

[TODO]: Add smtpd_data_restrictions = reject_unauth_pipelining to main.cf

3 participants

Back | FazBrowse Home | New Git URL