FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Rspamd: improve DKIM key generation by georglauterbach · Pull Request #3876 · docker-mailserver/docker-mailserver · GitHub

/ docker-mailserver Public

Rspamd: improve DKIM key generation - #3876

Merged
georglauterbach merged 4 commits into
masterfrom
rspamd/dkim
Feb 5, 2024
ConversationCommits (4)ChecksFiles changed
Merged

Rspamd: improve DKIM key generation#3876
georglauterbach merged 4 commits into
masterfrom
rspamd/dkim

Conversation

georglauterbach commented Feb 5, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Fixes #3873

Type of change

  • Improvement (non-breaking change that does improve existing functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary, I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added information about changes made in this PR to CHANGELOG.md

correct removal of old files with --force
a56efc9 
`rm` would fail when one of the files is not present, which is quite
undesirable log (not harmful until `set -e` is introduced).
use tmp log file
9781ade 
ref: #3873 (comment)
correct indentation
3b1d504
georglauterbach self-assigned this Feb 5, 2024
georglauterbach added area/scripts kind/improvement Improve an existing feature, configuration file or the documentation service/security/rspamd labels Feb 5, 2024
georglauterbach added this to the v14.0.0 milestone Feb 5, 2024
georglauterbach mentioned this pull request Feb 5, 2024
Closed
1 task
polarathene approved these changes Feb 5, 2024
View reviewed changes

polarathene left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Approving since __do_as_rspamd_user() only appears to be relevant to the rspamd DKIM generation script.

We'd have avoided all this if permissions on the config volume weren't relevant correct? After the LDAP feature rework is done I'll fix up DKIM keypair generation for v15 too.

georglauterbach commented Feb 5, 2024

Copy link
Copy Markdown
Member Author

We'd have avoided all this if permissions on the config volume weren't relevant correct?

Absolutely!

georglauterbach merged commit 4f222fe into master Feb 5, 2024
georglauterbach deleted the rspamd/dkim branch February 5, 2024 23:30
casperklein reviewed Feb 6, 2024
View reviewed changes
Comment thread target/bin/rspamd-dkim
Comment on lines +180 to +182
[[ -f ${PUBLIC_KEY_FILE} ]] && rm "${PUBLIC_KEY_FILE}"
[[ -f ${PUBLIC_KEY_DNS_FILE} ]] && rm "${PUBLIC_KEY_DNS_FILE}"
[[ -f ${PRIVATE_KEY_FILE} ]] && rm "${PRIVATE_KEY_FILE}"

casperklein Feb 6, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Maybe for a follow up "tuning":

rm -f "${PUBLIC_KEY_FILE}" etc. will always succeed, no matter if the file exist or not.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

casperklein casperklein left review comments
polarathene polarathene approved these changes

Assignees

georglauterbach

Labels

area/scripts kind/improvement Improve an existing feature, configuration file or the documentation service/security/rspamd

Projects

Rspamd Integration
Archived in project

Milestone

v14.0.0

Development

Successfully merging this pull request may close these issues.

Rspamd create dkim key permissions errors

3 participants

Back | FazBrowse Home | New Git URL