doc: add an example for using the keytype ed25519 when using DKIM & Rspamd - #4243
Merged
georglauterbach merged 1 commit intoOct 30, 2024
Merged
doc: add an example for using the keytype ed25519 when using DKIM & Rspamd#4243georglauterbach merged 1 commit into
georglauterbach merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
georglauterbach
enabled auto-merge (squash)
October 29, 2024 23:03
polarathene
approved these changes
Oct 30, 2024
Comment thread
target/bin/rspamd-dkim
Comment on lines
+58
to
+60
| ${LWHITE}setup config dkim keytype ed25519 domain edward.com selector elliptic-test${RESET} | ||
| Generate the DKIM key using the ED25519 elliptic curve for the domain | ||
| edward.com and the selector elliptic-test. |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
- Any reason to use edward.com instead of example.com placeholder?
- A selector example was already provided and probably isn't adding much here?
Revised suggestion if you agree:
Suggested change
| ${LWHITE}setup config dkim keytype ed25519 domain edward.com selector elliptic-test${RESET} | |
| Generate the DKIM key using the ED25519 elliptic curve for the domain | |
| edward.com and the selector elliptic-test. | |
| ${LWHITE}setup config dkim keytype ed25519 domain example.com${RESET} | |
| Generate a DKIM key for the domain 'example.com' but with ED25519 instead of RSA. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Please don't hesitate to adjust the code; the PR has been merged with auto-merge. I used "edward.com" because of ed25519 is based on Edward's Elliptical curve; but we can stick with example.com and remove the selector.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4180
Type of change
Checklist
No CHANGELOG.md entry required.