FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: SASLAuth - Drop services for `mysql`, `shadow`, `pam` auth mechanisms by polarathene · Pull Request #4259 · docker-mailserver/docker-mailserver · GitHub

fix: SASLAuth - Drop services for mysql, shadow, pam auth mechanisms - #4259

Merged
polarathene merged 6 commits into
docker-mailserver:masterfrom
polarathene:fix/saslauthd-drop-invalid-mysql-config
Nov 20, 2024
Merged

fix: SASLAuth - Drop services for mysql, shadow, pam auth mechanisms#4259
polarathene merged 6 commits into
docker-mailserver:masterfrom
polarathene:fix/saslauthd-drop-invalid-mysql-config

Conversation

polarathene commented Nov 10, 2024
edited
Loading

Copy link
Copy Markdown
Member

Description

SASLAUTHD_MECHANISMS only has test coverage for ldap and rimap, which were discussed during the original implementation of the feature.

The other mechanisms were added for the sake of it, but likely don't make much sense with DMS.

  • Potentially pam would as it appears to be the way to leverage databases like mysql for authentication.
  • mysql has not been a valid value for well over a decade. It's likely never worked in DMS.

Generally SASLAUTHD related support is not necessary for users. It was contributed as an alternative SASL auth method for Postfix to use when DMS has Dovecot disabled that would normally be delegated for SASL authentication.

Users interested in MySQL or similar DB access could configure for such directly with Postfix and Dovecot (or just Dovecot due to existing SASL auth config).

There may be potential breakage with SMTP_ONLY=1 users. I've not considered this as our support/docs for such are lacking. As this is for a breaking release, it should be fine and we can easily bring these back should users raise issues about it.

Docs wise, I don't see how the note about multiple values for mechanisms being supported was valid. Perhaps it was for direct usage of the command but not with how we start the supervisord services.

Fixes #4251


UPDATE: I forgot to remove these values from our reference ENV file, mailserver.env. This has been spotted and contributed: #4472

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • New and existing unit tests pass locally with my changes
  • I have added information about changes made in this PR to CHANGELOG.md

Comment thread CHANGELOG.md Outdated
polarathene changed the title Fix/saslauthd-drop-invalid-mysql-config fix: SASLAuth - Drop services for mysql, shadow, pam auth mechanisms Nov 10, 2024
polarathene added this to the v15.0.0 milestone Nov 10, 2024
polarathene self-assigned this Nov 10, 2024

polarathene commented Nov 10, 2024
edited
Loading

Copy link
Copy Markdown
Member Author

Heads-up, do not merge this PR.

It's waiting on @pwntester for advice (if any), relating to our CI docs preview no longer working for PRs coming from forks: #4247 (comment)

EDIT: Resolved and verified by #4267

Copy link
Copy Markdown
Contributor

Documentation preview for this PR is ready! 🎉

Built with commit: cefc1d8

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TODO]: Remove mysql from valid SASLAUTHD_MECHANISMS

2 participants


Back | FazBrowse Home | New Git URL