FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: `start-mailserver.sh` requires `mail_state.sh` to be sourced on restarts by polarathene · Pull Request #4417 · docker-mailserver/docker-mailserver · GitHub

/ docker-mailserver Public

fix: start-mailserver.sh requires mail_state.sh to be sourced on restarts - #4417

Merged
casperklein merged 1 commit into
masterfrom
fix/source-mailstate-script-for-restart-support
Mar 16, 2025
ConversationCommits (1)ChecksFiles changed
Merged

fix: start-mailserver.sh requires mail_state.sh to be sourced on restarts#4417
casperklein merged 1 commit into
masterfrom
fix/source-mailstate-script-for-restart-support

Conversation

polarathene commented Mar 16, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Spotted from logs of #4416 (comment)

  • Our test suite doesn't have coverage for restart support, so this went unnoticed and wasn't caught in review (fix: Better support container restarts #4323 (comment)).
  • While the first restart supported method we call is part of setup-stack.sh, the 2nd call lives at setup.d/mail_state.sh, thus we need to source it to be able to call it.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • New and existing unit tests pass locally with my changes
  • I have added information about changes made in this PR to CHANGELOG.md

polarathene added area/scripts kind/bug/fix A fix (PR) for a confirmed bug labels Mar 16, 2025
polarathene added this to the v15.0.1 milestone Mar 16, 2025
polarathene self-assigned this Mar 16, 2025
polarathene mentioned this pull request Mar 16, 2025
Closed
1 task
casperklein merged commit 7c680a0 into master Mar 16, 2025
casperklein deleted the fix/source-mailstate-script-for-restart-support branch March 16, 2025 14:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

casperklein casperklein approved these changes
georglauterbach georglauterbach approved these changes

Assignees

polarathene

Labels

area/scripts kind/bug/fix A fix (PR) for a confirmed bug

Projects

None yet

Milestone

v15.0.1

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL