| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
Changed the description of OVERRIDE_HOSTNAME environment variable, to raise awareness of unforeseen side effects.
Updated CHANGELOG to reflect changes in `mailserver.env`
removed trailing whitepace
Added reference to PR like other entries
Align comment in mailserver.env with docs docker-mailserver#4492 (comment)
There was a problem hiding this comment.
Sorry about the delay, I spent the last few days verbosely documenting a related observation but with rDNS behaviour (when relying on our advised --hostname, which OVERRIDE_HOSTNAME approach was not affected by).
I've manually updated your PR with changes I wanted to wrap this up, so LGTM now 👍
Thanks for contributing to the project and helping it improve for other users 😁
Sorry, something went wrong.
|
Documentation preview for this PR is ready! 🎉 Built with commit: 37b2a5f |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Changed the description of OVERRIDE_HOSTNAME environment variable, to raise awareness of unforeseen side effects.
Description
The current documentation of OVERRIDE_HOSTNAME in mailserver.env doesnt reflect the fact that setting this can lead to unforeseen problems. See explanation at the bottom of this comment #4484 (comment)
When setting up DMS the first time i thought it would be better to set it to make sure all internal services use the correct hostname. When in reality its better not to set this unless you need to.
While at it i reformated the text so it looks more like the rest of the comments in the file. Now with no trailing whitespaces.
Type of change
Checklist
I dont think this is necessary since the documentation already tells to only set this when you cant change the hostname.
No tests necessary, since this only changes a comment.
No tests necessary, since this only changes a comment.