FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

update: added html sanitizer for remote rendering by anikethsaha · Pull Request #1128 · docsifyjs/docsify · GitHub

  1. docsifyjs
  2. docsify

Repository navigation

update: added html sanitizer for remote rendering - #1128

Merged
anikethsaha merged 3 commits into
docsifyjs:developfrom
anikethsaha:fix-validating-remote-content
Jun 17, 2020
ConversationCommits (3)ChecksFiles changed
Merged

update: added html sanitizer for remote rendering#1128
anikethsaha merged 3 commits into
docsifyjs:developfrom
anikethsaha:fix-validating-remote-content

Conversation

anikethsaha commented Apr 21, 2020

Copy link
Copy Markdown
Member

Summary
Added DOMPurifier for validating content coming from remote url
#1126

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
    You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome

  • Firefox

  • Safari

  • Edge

  • IE

anikethsaha commented Apr 21, 2020

Copy link
Copy Markdown
Member Author

cc @Sharifi-Amin

anikethsaha requested review from a team and QingWei-Li April 21, 2020 10:16
QingWei-Li reviewed Apr 22, 2020
View reviewed changes
Comment thread package.json
QingWei-Li previously approved these changes Apr 22, 2020
View reviewed changes
trusktr requested changes Apr 26, 2020
View reviewed changes

trusktr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hang on, I have an idea for isExternal.

trusktr approved these changes Apr 26, 2020
View reviewed changes
Comment thread src/core/render/index.js Outdated

trusktr commented Apr 26, 2020

Copy link
Copy Markdown
Member

Ooops, let me fix lint errors.

trusktr commented Apr 26, 2020

Copy link
Copy Markdown
Member

There's also another isExternal check here:

docsify/src/core/render/index.js

Line 260 in b2e6123

const isExternal = /(?:http[s]?:)?\/\//.test(config.logo);

It should probably re-use the same trick.

trusktr requested changes Apr 26, 2020
View reviewed changes

trusktr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Fixed my lint errors: anikethsaha#2

anikethsaha commented Apr 27, 2020
View reviewed changes
Comment thread packages/docsify-server-renderer/index.js Outdated
Comment thread packages/docsify-server-renderer/index.js Outdated

anikethsaha commented May 7, 2020

Copy link
Copy Markdown
Member Author

cc @trusktr Update ?

anikethsaha added the semver-patch This needs a patch release label May 18, 2020

vercel Bot commented May 21, 2020 •
edited
Loading

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/3unan0xu1
✅ Preview: https://docsify-previe-git-fork-anikethsaha-fix-validating-remot-df5960.docsify-core.vercel.app

trusktr reviewed May 21, 2020
View reviewed changes
Comment thread src/core/render/index.js Outdated
trusktr mentioned this pull request May 21, 2020
Open
This was referenced May 22, 2020
Closed
Merged
anikethsaha force-pushed the fix-validating-remote-content branch from 45023a4 to 1e3dd13 Compare June 14, 2020 07:12

codesandbox-ci Bot commented Jun 14, 2020 •
edited
Loading

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1d46637:

Sandbox Source
priceless-night-80tqp Configuration

trusktr approved these changes Jun 17, 2020
View reviewed changes

trusktr left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Needs tests. I'm adding some in my branch, currently in the tmp-update-server branch. I will make a better branch name before I'm make a PR to the main repo...

But for now, do you want to to merge this as is without tests? Or do you want to wait?

Personally I think we can get it merged, but not release yet.

anikethsaha commented Jun 17, 2020 •
edited
Loading

Copy link
Copy Markdown
Member Author

I will try to write tests for this. after that I guess we can merge it.

trusktr mentioned this pull request Jun 17, 2020
Draft
7 of 21 tasks
anikethsaha merged commit 714ef29 into docsifyjs:develop Jun 17, 2020
snyk-bot mentioned this pull request Jun 26, 2020
Merged
trusktr added a commit that referenced this pull request Jul 4, 2020
Merge branch 'develop' into docsify-class
fc71b56 
* develop:
  docs: removed codefund docs and plugin (#1262)
  docs: remove bundle size from the home page and documentation (#1257)
  fix: search can not search the table header (#1256)
  fix: after setting the background image, the button is obscured (#1234)
  Fix: fixed onlycover flag in mobile (#1243)
  fix: Updated docs with instructions for installing specific version (fixes #780) (#1225)
  fix: Add error handling for missing dependencies (fixes #1210) (#1232)
  [documdocs:  deploy docsify in docker. (#1241)
  docs: Add embed gist instructions to Embed Files (fixes #932 ) (#1238)
  chore: add changelog 4.11.4
  [build] 4.11.4
  feat: added html sanitizer for remote rendering (#1128)
jhildenbiddle mentioned this pull request Feb 5, 2021
Merged
4 of 7 tasks

This branch was successfully deployed

1 active deployment
Preview — 1d466375 Deployed Jun 17, 2020 by vercel[bot]
View deployment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

trusktr trusktr approved these changes
sy-records sy-records approved these changes
QingWei-Li Awaiting requested review from QingWei-Li
jhildenbiddle Awaiting requested review from jhildenbiddle
Koooooo-7 Awaiting requested review from Koooooo-7

Assignees

No one assigned

Labels

semver-patch This needs a patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL