FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix Vue Reactivity by jhildenbiddle · Pull Request #1271 · docsifyjs/docsify · GitHub

  1. docsifyjs
  2. docsify

Repository navigation

Fix Vue Reactivity - #1271

Merged
jhildenbiddle merged 11 commits into
developfrom
fix-790
Oct 8, 2020
ConversationCommits (11)ChecksFiles changed
Merged

Fix Vue Reactivity#1271
jhildenbiddle merged 11 commits into
developfrom
fix-790

Conversation

jhildenbiddle commented Jul 5, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes #788 #790 #1074 #1252 #1364

  • Fix inability to instantiate reactive Vue components by 1) handling each child of #main instead of #main itself and 2) skipping elements that are already Vue instances
  • Retain previous behavior of handling basic Vue rendering without the need for a markdown <script> tag.
  • Add Vue3 support
  • Update documentation and add live Vue examples
  • Update index.html files to include Vue.js
  • Update Cypress Jest+Playwright e2e tests

Summary: Docsify was mounting #main as a Vue component on every page change when it detected Vue.js, presumably to process basic Vue content without requiring a <script> tag in each markdown file. The issue is that this was happening after users had already instantiated child elements of #main as Vue components, destroying those instances.

Fix Vue compatibility (fix #790)
f385e21 
- Fix inability to instantiate reactive Vue components by 1) handling each child of #main instead of #main itself and 2)  skipping elements that are already Vue instances
- Retain previous behavior of processing basic Vue rendering without the need for a markdown <script> tag.
- Update documentation and add live Vue examples
- Update `index.html` files to include Vue.js and Vuep (CSS+JS)
Merge branch 'develop' into fix-790
aa1d1e6 
# Conflicts:
#	docs/index.html

vercel Bot commented Jul 5, 2020 •
edited
Loading

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/gw3jsrcph
✅ Preview: https://docsify-preview-git-fix-790.docsify-core.vercel.app

codesandbox-ci Bot commented Jul 5, 2020 •
edited
Loading

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4f6148d:

Sandbox Source
docsify-template Configuration

jhildenbiddle commented Jul 5, 2020
View reviewed changes
Comment thread src/core/render/index.js
anikethsaha approved these changes Jul 5, 2020
View reviewed changes

anikethsaha left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is really awesome

jhildenbiddle self-assigned this Jul 5, 2020
Koooooo-7 previously approved these changes Jul 5, 2020
View reviewed changes

Koooooo-7 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Awesome ! 👍

anikethsaha previously approved these changes Jul 5, 2020
View reviewed changes
sy-records previously approved these changes Jul 5, 2020
View reviewed changes
trusktr previously requested changes Jul 5, 2020
View reviewed changes

trusktr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is a good change, but let's add unit tests.

Comment thread docs/index.html Outdated
Comment thread src/core/render/index.js

anikethsaha commented Jul 5, 2020

Copy link
Copy Markdown
Member

This is a good change, but let's add unit tests.

tests fixtures (e2e-cypress) have been updated. But yea unit/integration tests would be great to add. But is it possible to do unit testing for this change ? if so, it would be great to add.

trusktr reviewed Jul 5, 2020
View reviewed changes
Comment thread src/core/render/index.js Outdated
trusktr reviewed Jul 5, 2020
View reviewed changes
Comment thread src/core/render/index.js Outdated
jhildenbiddle mentioned this pull request Jul 5, 2020
Closed
1 task done
jhildenbiddle linked an issue Jul 5, 2020 that may be closed by this pull request
Dynamic content in Vue components #1074
Closed
1 task done
Updates per request
105fbbf 
- When Vue.js is detected, markdown `<script>` is not executed when executeScript is `false` (matches previous behavior)
- Minor code tweaks that do not affect functonality
jhildenbiddle dismissed stale reviews from sy-records, anikethsaha, and Koooooo-7 via 105fbbf July 6, 2020 01:15
jhildenbiddle mentioned this pull request Jul 8, 2020
Merged
10 of 18 tasks
jhildenbiddle added the vuejs related to Vue.js label Jul 8, 2020
anikethsaha previously approved these changes Oct 7, 2020
View reviewed changes
jhildenbiddle dismissed trusktr’s stale review October 7, 2020 20:48

Outdated / Issues Resolved

This was referenced Oct 7, 2020
Closed
Closed
Closed
jhildenbiddle linked an issue Oct 8, 2020 that may be closed by this pull request
How to create global vue variables in html and make it readable on .md files? #1252
Closed
This was linked to issues Oct 8, 2020
Vue not working with reactivity #790
Closed
Support Vue3 #1364
Closed
jhildenbiddle merged commit 761210c into develop Oct 8, 2020
This was referenced Oct 8, 2020
Closed
Closed
jhildenbiddle deleted the fix-790 branch October 8, 2020 22:07
sy-records mentioned this pull request Feb 5, 2021
Merged
3 tasks done
This was referenced Mar 9, 2021
Merged
Open
Closed
Merged
dependabot Bot mentioned this pull request Mar 17, 2021
Merged

This branch was successfully deployed

1 active deployment
Preview — 4f6148db Deployed Oct 8, 2020 by vercel[bot]
View deployment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

anikethsaha anikethsaha approved these changes
sy-records sy-records approved these changes
trusktr Awaiting requested review from trusktr
Koooooo-7 Awaiting requested review from Koooooo-7

Assignees

jhildenbiddle

Labels

vuejs related to Vue.js

Projects

None yet

Milestone

No milestone

5 participants

Back | FazBrowse Home | New Git URL