FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Make grammatical changes by bharat-patodi · Pull Request #1296 · docsifyjs/docsify · GitHub

  1. docsifyjs
  2. docsify

Repository navigation

Make grammatical changes - #1296

Merged
anikethsaha merged 5 commits into
docsifyjs:developfrom
bharat-patodi:patch-1
Jul 26, 2020
ConversationCommits (5)ChecksFiles changed
Merged

Make grammatical changes#1296
anikethsaha merged 5 commits into
docsifyjs:developfrom
bharat-patodi:patch-1

Conversation

bharat-patodi commented Jul 20, 2020

Copy link
Copy Markdown
Contributor

Minor changes.
Solely for improving readability.

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Repo settings
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Make grammatical changes
5b42627 
Minor changes.
Solely for improving readability.

vercel Bot commented Jul 20, 2020 •
edited
Loading

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/iqa6y7rr3
✅ Preview: https://docsify-preview-git-fork-bharat-patodi-patch-1.docsify-core.vercel.app

codesandbox-ci Bot commented Jul 20, 2020 •
edited
Loading

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d57269e:

Sandbox Source
docsify-template Configuration

anikethsaha requested changes Jul 20, 2020
View reviewed changes

anikethsaha left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

One suggestion. otherwise LGTM

Comment thread docs/configuration.md Outdated

bharat-patodi commented Jul 20, 2020

Copy link
Copy Markdown
Contributor Author

Hi,

I have incorporated the changes.
Hope that helps.

Thanks

sy-records approved these changes Jul 21, 2020
View reviewed changes

sy-records left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

Koooooo-7 approved these changes Jul 21, 2020
View reviewed changes

Koooooo-7 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

thx for ur contributions.:+1:

bharat-patodi commented Jul 26, 2020

Copy link
Copy Markdown
Contributor Author

So, with 3 approvals, can the PR be merged?
Or I have to do something somehow?
Pretty new to this, so...

anikethsaha merged commit 1a64dc8 into docsifyjs:develop Jul 26, 2020
snyk-bot mentioned this pull request Aug 21, 2020
Closed
snyk-bot mentioned this pull request Sep 12, 2020
Merged

This branch was successfully deployed

1 active deployment
Preview — d57269e1 Deployed Jul 26, 2020 by vercel[bot]
View deployment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

anikethsaha anikethsaha approved these changes
Koooooo-7 Koooooo-7 approved these changes
sy-records sy-records approved these changes
trusktr Awaiting requested review from trusktr
jhildenbiddle Awaiting requested review from jhildenbiddle

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL