| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
When resolving fallback page for the path (`fallbackLanguages` option), we should consider the original path, not the file location (which could be different when aliases are used).
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/o4e3vnsjx |
Sorry, something went wrong.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b896d63:
|
Sorry, something went wrong.
There was a problem hiding this comment.
I think there is a linting issue, Can you fix that. ?
Also, it would be great to have some tests for this.
Sorry, something went wrong.
|
@anikethsaha Fixed linter issue. Added a Cypress test (couldn't find any unit-level tests for these functionality 🤷🏻♂️). |
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM.
@anikethsaha The previous branch is wrong, if it is merged, it will be submitted to master.
Sorry, something went wrong.
|
coool Thanks |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Summary
When resolving fallback page for the path (fallbackLanguages option), we should consider the original path, not the file location (which could be different when aliases are used).
This patch is used in this repo and "deployed" at https://test-prof.evilmartians.io/.
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.