FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix : add patch for {docsify-ignore} and {docsify-ignore-all} by sy-records · Pull Request #1351 · docsifyjs/docsify · GitHub

  1. docsifyjs
  2. docsify

Repository navigation

fix : add patch for {docsify-ignore} and {docsify-ignore-all} - #1351

Merged
sy-records merged 5 commits into
docsifyjs:developfrom
sy-records:reset-1318
Aug 22, 2020
ConversationCommits (5)ChecksFiles changed
Merged

fix : add patch for {docsify-ignore} and {docsify-ignore-all}#1351
sy-records merged 5 commits into
docsifyjs:developfrom
sy-records:reset-1318

Conversation

sy-records commented Aug 22, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Summary

<!-- {docsify-ignore} --> is a major change and should be put into v5.

But a version has already been released, so a patch version has been added that is compatible with older versions and can be removed in v5.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Repo settings
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

vercel Bot commented Aug 22, 2020 •
edited
Loading

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/kquxak60d
✅ Preview: https://docsify-preview-git-fork-sy-records-reset-1318.docsify-core.vercel.app

codesandbox-ci Bot commented Aug 22, 2020 •
edited
Loading

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 204bfbb:

Sandbox Source
docsify-template Configuration

sy-records added regression semver-major This needs a major release semver-patch This needs a patch release and removed semver-major This needs a major release labels Aug 22, 2020
Koooooo-7 requested changes Aug 22, 2020
View reviewed changes

Koooooo-7 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think we should keep the <!-- {docsify-ignore} --> and also let the {docsify-ignore} work fine, in case of causing the second breaking for users who may already use the new option.

sy-records requested a review from Koooooo-7 August 22, 2020 02:31
sy-records marked this pull request as draft August 22, 2020 02:38
sy-records marked this pull request as ready for review August 22, 2020 02:52

anikethsaha commented Aug 22, 2020

Copy link
Copy Markdown
Member

I agree with @Koooooo-7 if we can manage to to ship the changes it would be great.
Though I will not wait too much cause we need to do the patch release soon

sy-records commented Aug 22, 2020

Copy link
Copy Markdown
Member Author

@anikethsaha @Koooooo-7 Done.

In #1318, I had a reference to the need for compatibility. #1318 (review)

sy-records changed the title revert: Convert {docsify-ignore} and {docsify-ignore-all} to HTML comments fix : add patch for {docsify-ignore} and {docsify-ignore-all} Aug 22, 2020
Koooooo-7 approved these changes Aug 22, 2020
View reviewed changes

Koooooo-7 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

TODO: when and how we will solve it.

sy-records commented Aug 22, 2020

Copy link
Copy Markdown
Member Author

TODO: when and how we will solve it.

Awaiting @trusktr and @jhildenbiddle approval, release v4.11.6

trusktr approved these changes Aug 22, 2020
View reviewed changes

trusktr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. For later, we can revert the PR merge commit to re-create these changes. We can open a PR with the changes, and just keep it open for v5 until we're ready.

trusktr commented Aug 22, 2020

Copy link
Copy Markdown
Member

Should we revert the removal of src from publish, then remove it as a breaking change for v5? Thoughts @jhildenbiddle?

sy-records commented Aug 22, 2020

Copy link
Copy Markdown
Member Author

Should we revert the removal of src from publish, then remove it as a breaking change for v5? Thoughts @jhildenbiddle?

#1343 (comment)

trusktr requested changes Aug 22, 2020
View reviewed changes

trusktr left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for doing this! This is good, to keep both forms.

trusktr approved these changes Aug 22, 2020
View reviewed changes

trusktr left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Oops. Looks good! Let's get this in.

sy-records commented Aug 22, 2020 •
edited
Loading

Copy link
Copy Markdown
Member Author

@trusktr Do we have to wait for @jhildenbiddle ? Or can we merge and release patch versions now?

sy-records merged commit ce31607 into docsifyjs:develop Aug 22, 2020
sy-records deleted the reset-1318 branch August 22, 2020 11:25
snyk-bot mentioned this pull request Sep 12, 2020
Merged

This branch was successfully deployed

1 active deployment
Preview — 204bfbba Deployed Aug 22, 2020 by vercel[bot]
View deployment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

trusktr trusktr approved these changes
anikethsaha anikethsaha approved these changes
Koooooo-7 Koooooo-7 approved these changes
jhildenbiddle Awaiting requested review from jhildenbiddle

Assignees

No one assigned

Labels

regression semver-patch This needs a patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL