Repository navigation
fix: sidebar title error - #1360
Merged
sy-records merged 2 commits intoAug 26, 2020
Merged
sy-records merged 2 commits into
sy-records merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/5wkeh94ae |
Sorry, something went wrong.
Copy link
Copy Markdown
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 45bd355:
|
Sorry, something went wrong.
anikethsaha
approved these changes
Aug 26, 2020
anikethsaha
requested changes
Aug 26, 2020
Comment thread
src/core/event/sidebar.js
anikethsaha
previously approved these changes
Aug 26, 2020
sy-records
requested review from
Koooooo-7,
anikethsaha,
jhildenbiddle and
trusktr
August 26, 2020 10:56
anikethsaha
approved these changes
Aug 26, 2020
Koooooo-7
approved these changes
Aug 26, 2020
1 task done
This was referenced Mar 9, 2021
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix #1359
Bugs caused by #1286
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.