FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Describe ordering requirement for prism script tag by ablakey · Pull Request #1935 · docsifyjs/docsify · GitHub

Repository navigation

Describe ordering requirement for prism script tag - #1935

Merged
Koooooo-7 merged 1 commit into
docsifyjs:developfrom
ablakey:patch-1
Dec 12, 2022
Merged

Koooooo-7 merged 1 commit into
docsifyjs:developfrom
ablakey:patch-1

Conversation

ablakey commented Dec 10, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

I couldn't get a prism typescript language grammar to work until I realised that script order mattered.

This might not be the best language or format for this, but I think it probably belongs in the documentation in some manner.

What kind of change does this PR introduce?

For any code change,

  • Related documentation has been updated if needed
  • Related tests have been updated or tests have been added

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

Related issue, if any:

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

I couldn't get a prism typescript language grammar to work until I realised that script order mattered.   

This might not be the best language or format for this, but I think it probably belongs in the documentation in some manner.

Thank you!

vercel Bot commented Dec 10, 2022 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
docsify-preview ✅ Ready (Inspect) Visit Preview Dec 10, 2022 at 3:31PM (UTC)

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 342d93c:

Sandbox Source
docsify-template Configuration

sy-records requested a review from a team December 11, 2022 00:27
Koooooo-7 merged commit f4cae7f into docsifyjs:develop Dec 12, 2022

Koooooo-7 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

This branch was successfully deployed

1 active deployment
Preview — 342d93cf Deployed Dec 10, 2022 by vercel[bot]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL