FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

docs: add notes on "hash" vs "history" routing in the config docs by trusktr · Pull Request #1970 · docsifyjs/docsify · GitHub

  1. docsifyjs
  2. docsify

Repository navigation

docs: add notes on "hash" vs "history" routing in the config docs - #1970

Merged
trusktr merged 5 commits into
developfrom
update-routerMode-docs
Jul 16, 2023
ConversationCommits (5)ChecksFiles changed
Merged

docs: add notes on "hash" vs "history" routing in the config docs#1970
trusktr merged 5 commits into
developfrom
update-routerMode-docs

Conversation

trusktr commented Jan 23, 2023

Copy link
Copy Markdown
Member

Summary

expand routerMode docs.

What kind of change does this PR introduce?

Docs

For any code change,

  • Related documentation has been updated if needed
  • Related tests have been updated or tests have been added

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

Related issue, if any:

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

vercel Bot commented Jan 23, 2023 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docsify-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2023 5:18pm

codesandbox-ci Bot commented Jan 23, 2023 •
edited
Loading

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 61c9e4b:

Sandbox Source
docsify-template Configuration

sy-records changed the title add notes on "hash" vs "history" routing in the config docs docs: add notes on "hash" vs "history" routing in the config docs Jan 23, 2023
trusktr force-pushed the update-routerMode-docs branch from 7029c0c to 3feebc0 Compare January 23, 2023 03:32
trusktr force-pushed the update-routerMode-docs branch from 046c553 to e07060a Compare January 23, 2023 03:51

Koooooo-7 commented Jan 23, 2023

Copy link
Copy Markdown
Member

Maybe we could handle this config internally as a default alias config for sidebar and navbar instead of forcing user to config it manually .

trusktr commented Jan 26, 2023

Copy link
Copy Markdown
Member Author

@Koooooo-7 I think that may be possible, but I think it might be a breaking change, and would need to be something we plan for a following major.

Koooooo-7 approved these changes Jan 28, 2023
View reviewed changes

Koooooo-7 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

trusktr mentioned this pull request Jul 16, 2023
Open

trusktr commented Jul 16, 2023

Copy link
Copy Markdown
Member Author

@Koooooo-7 tracking that ^ issue in #2133

trusktr merged commit 4e01f4d into develop Jul 16, 2023
trusktr deleted the update-routerMode-docs branch July 16, 2023 17:23

This branch was successfully deployed

1 active deployment
Preview — dab6e1c1 Deployed Jul 16, 2023 by vercel[bot]
View deployment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Koooooo-7 Koooooo-7 approved these changes
sy-records Awaiting requested review from sy-records

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL