Repository navigation
Feat: Prevent focus on hidden sidebar - #2265
Merged
jhildenbiddle merged 3 commits intoNov 16, 2023
Merged
jhildenbiddle merged 3 commits into
jhildenbiddle merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sorry, something went wrong.
This was referenced Oct 17, 2023
trusktr
approved these changes
Oct 22, 2023
trusktr
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Nice! Can it be tested?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Technically speaking, yes we can test this. I'd prefer not to implement those tests with this PR for a few reasons:
I'd like to avoid this simple fix turning into a "test all the sidebar things" rabbit hole since it is (IMHO) a pretty basic fix. |
Sorry, something went wrong.
Koooooo-7
approved these changes
Nov 16, 2023
sy-records
approved these changes
Nov 16, 2023
This was referenced Dec 4, 2023
Merged
Closed
1 task
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
See title and original issue (below).
Related issue, if any:
#2225
What kind of change does this PR introduce?
Feature
For any code change,
Does this PR introduce a breaking change?
No
Tested in the following browsers: