FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: dev mode hot reload and add sourcemaps by jhildenbiddle · Pull Request #2402 · docsifyjs/docsify · GitHub

  1. docsifyjs
  2. docsify

Repository navigation

fix: dev mode hot reload and add sourcemaps - #2402

Merged
Koooooo-7 merged 3 commits into
developfrom
fix-dev-hot-reload
Apr 17, 2024
ConversationCommits (3)ChecksFiles changed
Merged

fix: dev mode hot reload and add sourcemaps#2402
Koooooo-7 merged 3 commits into
developfrom
fix-dev-hot-reload

Conversation

jhildenbiddle commented Apr 11, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Summary

Fixes two development issues:

  1. Hot reload was not working because the docs site was loading lib/docsify.min.js which was only updated on "production" builds. The build now generates minified and non-minified bundles for all builds.
  2. Source maps are now generated for all .min.js files in /lib/. This solution is best for troubleshooting during development because source maps provide unminified source code along with accurate file and line locations on errors. Using non-minified bundles for development was previously discussed, however this approach does not provide accurate source file and line locations.

Related issue, if any:

None

What kind of change does this PR introduce?

Bugfix
Build-related changes

For any code change,

N/A

Does this PR introduce a breaking change?

No

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari

vercel Bot commented Apr 11, 2024 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docsify-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 13, 2024 7:20am

jhildenbiddle self-assigned this Apr 11, 2024
jhildenbiddle added this to the 5.x milestone Apr 11, 2024
jhildenbiddle mentioned this pull request Apr 11, 2024
Merged
3 tasks done
jhildenbiddle requested a review from a team April 12, 2024 14:17
Koooooo-7 previously approved these changes Apr 13, 2024
View reviewed changes

Koooooo-7 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

Koooooo-7 requested a review from a team April 13, 2024 04:50
sy-records requested a review from Koooooo-7 April 13, 2024 07:20

jhildenbiddle commented Apr 15, 2024

Copy link
Copy Markdown
Member Author

@Koooooo-7 --

Awaiting approval to merge PR. Thx!

Koooooo-7 merged commit 947d8de into develop Apr 17, 2024
Koooooo-7 deleted the fix-dev-hot-reload branch April 17, 2024 03:52
sy-records mentioned this pull request May 5, 2025
Merged
sy-records mentioned this pull request Jul 17, 2026
Merged

This branch was successfully deployed

1 active deployment
Preview — e0a90ab6 Deployed Apr 13, 2024 by vercel[bot]
View deployment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Koooooo-7 Koooooo-7 approved these changes
sy-records sy-records approved these changes

Assignees

jhildenbiddle

Labels

None yet

Projects

None yet

Milestone

5.x

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL