FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

docs: add stormkit as deployment platform by eldemcan · Pull Request #2413 · docsifyjs/docsify · GitHub

  1. docsifyjs
  2. docsify

Repository navigation

docs: add stormkit as deployment platform - #2413

Merged
sy-records merged 2 commits into
docsifyjs:developfrom
eldemcan:patch-1
May 7, 2024
ConversationCommits (2)ChecksFiles changed
Merged

docs: add stormkit as deployment platform#2413
sy-records merged 2 commits into
docsifyjs:developfrom
eldemcan:patch-1

Conversation

eldemcan commented Apr 29, 2024

Copy link
Copy Markdown
Contributor

Summary

Add stormkit as deployment platform

Related issue, if any:

What kind of change does this PR introduce?

Docs

For any code change,

  • Related documentation has been updated, if needed
  • Related tests have been added or updated, if needed

Does this PR introduce a breaking change?

No

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge

vercel Bot commented Apr 29, 2024 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docsify-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2024 10:06pm

paulhibbitts commented Apr 29, 2024

Copy link
Copy Markdown
Member

Thanks for the PR @eldemcan . Following the provided instructions resulted in a 404 error - not familiar with StormKit but usually you need to set the folder to be served to 'docs', could you please update the PR with the needed info to do that? Thank you!

paulhibbitts self-assigned this Apr 29, 2024

eldemcan commented Apr 29, 2024

Copy link
Copy Markdown
Contributor Author

Thanks for the PR @eldemcan . Following the provided instructions resulted in a 404 error - not familiar with StormKit but usually you need to set the folder to be served to 'docs', could you please update the PR with the needed info to do that? Thank you!

Hi @paulhibbitts
Thanks for looking into this PR, I updated step to set output folder to docs.

paulhibbitts self-requested a review April 30, 2024 14:48
paulhibbitts reviewed Apr 30, 2024
View reviewed changes

paulhibbitts left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good to me.

paulhibbitts added the docs related to the documentation of docsify itself label Apr 30, 2024
eldemcan requested a review from paulhibbitts May 6, 2024 18:06

eldemcan commented May 6, 2024

Copy link
Copy Markdown
Contributor Author

Hi @paulhibbitts, is there anything I need to do before this is merged ?

sy-records approved these changes May 7, 2024
View reviewed changes

sy-records left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. Thank you!

sy-records merged commit 11015fe into docsifyjs:develop May 7, 2024

paulhibbitts commented May 7, 2024

Copy link
Copy Markdown
Member

Thanks for merging the PR @sy-records!

This branch was successfully deployed

1 active deployment
Preview — 68b06508 Deployed Apr 29, 2024 by vercel[bot]
View deployment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

sy-records sy-records approved these changes
paulhibbitts Awaiting requested review from paulhibbitts

Assignees

paulhibbitts

Labels

docs related to the documentation of docsify itself

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL