| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sorry, something went wrong.
|
Hi @Koooooo-7 , thanks very much for taking a go at this! I've made a little test site using the PR Preview: An image with two classes worked like a charm. Is this feature also expected to work for text links? I ask because with v5 there are now two classes for defining buttons, button + primary and button + secondary. Hope I did everything with in my test page 🙂 PS - GitHub renders the page with the markup quite cleanly still: https://github.com/paulhibbitts/docsify-v5-multiple-value-config-test/blob/main/multiple-values-example.md |
Sorry, something went wrong.
Yep, I think this should work either. [logo-link](https://docsify.js.org/_media/icon.svg ':id=someCssId :class=someCssClass :target=_self :class=anotherCssClass :disabled')
Your working as fast as the rocket shoot ! 🚀 |
Sorry, something went wrong.
|
Thats awesome @Koooooo-7 , this initial support for multiple classes is VERY useful 🙌🏻 Thank you! |
Sorry, something went wrong.
There was a problem hiding this comment.
This is looking really good! The PR Preview has been tested on the following page: https://paulhibbitts.github.io/docsify-v5-multiple-value-config-test/#/multiple-values-example
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM.
Sorry, something went wrong.
Co-authored-by: Luffy <lufei@docsifyjs.org>
|
Should we only allow class?  |
Sorry, something went wrong.
Currently, in our scope, only class are necessary to supported multi values. Personally, I think it is okay cuz user needs follow the rules. and if the config not work as expected, they can be aware of that either. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Summary
An enhancement for helper configs which support multi values, it will be retrieved all.
It is short term goal to find middle ground to solve the problem that allowing config a key multi times.
For single value support, it keeps the consistency of current config behaviors and we docs them as single value configs either. So there is no breaking change introduced.
A further assumption is making new docsify config system to support more flexible configuration.
Trace on #2476
Related issue, if any:
What kind of change does this PR introduce?
For any code change,
Does this PR introduce a breaking change?
No
Yes
No
Tested in the following browsers: