FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: update relative link handling by sy-records · Pull Request #2579 · docsifyjs/docsify · GitHub

Repository navigation

fix: update relative link handling - #2579

Merged
sy-records merged 2 commits into
docsifyjs:developfrom
sy-records:fix/link
Aug 30, 2025
Merged

sy-records merged 2 commits into
docsifyjs:developfrom
sy-records:fix/link

Conversation

sy-records commented Jul 25, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Close #1929
Close #2300
Close #1987

Convert the link to an absolute path.

vercel Bot commented Jul 25, 2025 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docsify-preview Ready Preview Comment Aug 25, 2025 2:36am

Koooooo-7 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

any change on this...? I thought it is a refactor. 🔨

Comment on lines +37 to +39
href = router
.toURL(href, null, router.getCurrentPath())
.replace(/^#\//, '/');

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Fix this here by calling toURL to handle relative paths according to routerMode.

sy-records merged commit eeacfcc into docsifyjs:develop Aug 30, 2025
6 checks passed
sy-records deleted the fix/link branch August 30, 2025 03:25
sy-records mentioned this pull request Jul 3, 2026

This branch was successfully deployed

1 active deployment
Preview — e2c3aeaa Deployed Aug 25, 2025 by vercel[bot]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

noCompileLinks and relativePath are not working well together Relative path link with ':ignore' dosen't work

2 participants


Back | FazBrowse Home | New Git URL