FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

docs: remove loading dialog section from quickstart guide by sy-records · Pull Request #2585 · docsifyjs/docsify · GitHub

  1. docsifyjs
  2. docsify

Repository navigation

docs: remove loading dialog section from quickstart guide - #2585

Merged
sy-records merged 1 commit into
docsifyjs:developfrom
sy-records:docs/quickstart
Aug 7, 2025
ConversationCommits (1)ChecksFiles changed
Merged

docs: remove loading dialog section from quickstart guide#2585
sy-records merged 1 commit into
docsifyjs:developfrom
sy-records:docs/quickstart

Conversation

sy-records commented Jul 30, 2025

Copy link
Copy Markdown
Member

Summary

After merging #1466, I discovered #1458 (comment).

It seems that data-app does not currently have any practical use? And there is a new Loading.

Perhaps data-app is used in Vue. However, I tested it without adding it, and it worked fine.

So I removed this part of the content.

Related issue, if any:

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

For any code change,

  • Related documentation has been updated, if needed
  • Related tests have been added or updated, if needed

Does this PR introduce a breaking change?

  • Yes
  • No

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge

vercel Bot commented Jul 30, 2025 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docsify-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2025 2:34am

Koooooo-7 reviewed Jul 30, 2025
View reviewed changes

Koooooo-7 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

In the v4, the Loading dialog support customize the Loading content even inserting DOMs.

<div id="app"> I'm loading ... </div>

For now when we change the content, we'll see the loading effect and the content mess up.
I suppose we should have a fix on it...

sy-records commented Jul 31, 2025

Copy link
Copy Markdown
Member Author

Modifying it requires adding some styles.

docsify/src/themes/shared/_app.css

Lines 126 to 133 in 77d93fa

#app {
display: flex;
align-items: center;
justify-content: center;
gap: 0.75em;
height: 100vh;
padding-inline: 50px;
}

There is a new loading screen in v5. I think we can remove it without fixing it.

Koooooo-7 commented Jul 31, 2025

Copy link
Copy Markdown
Member

There is a new loading screen in v5. I think we can remove it without fixing it.

Cuz I thought it was a feature in v4 that user can customize the loading page easily.
I'm ok with it to remove this feature, if user urges to add it back, we could refine it then.

sy-records merged commit 4c9e111 into docsifyjs:develop Aug 7, 2025
sy-records deleted the docs/quickstart branch August 7, 2025 02:32
sy-records mentioned this pull request Sep 2, 2025
Closed

This branch was successfully deployed

1 active deployment
Preview — 85c28e66 Deployed Aug 7, 2025 by vercel[bot]
View deployment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Koooooo-7 Koooooo-7 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL