Repository navigation
fix: normalize slugs to NFC and remove emoji variation selector - #2597
Merged
sy-records merged 4 commits intoSep 2, 2025
Merged
sy-records merged 4 commits into
sy-records merged 4 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Hi again @sy-records , please ignore my earlier reply as I misunderstood the issue being addressed, hopefully now I understand it and have verified the fix with my own Docsify v5 test site. https://paulhibbitts.github.io/docsify-v5-emoji-test/#/emoji Does this help confirm your fix? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
That's right. Legacy Style ⚠️ should be legacy-style-, while the previous version was legacy-style-%ef%b8%8f café before:
U+0063 : LATIN SMALL LETTER C
U+0061 : LATIN SMALL LETTER A
U+0066 : LATIN SMALL LETTER F
U+0065 : LATIN SMALL LETTER E
U+0301 : COMBINING ACUTE ACCENT {stress mark; Greek oxia, tonos}
current:
U+0063 : LATIN SMALL LETTER C
U+0061 : LATIN SMALL LETTER A
U+0066 : LATIN SMALL LETTER F
U+00E9 : LATIN SMALL LETTER E WITH ACUTE
|
Sorry, something went wrong.
Closed
trusktr
added a commit
that referenced
this pull request
Nov 17, 2025
* develop: (126 commits) refactor: improve blockquoteCompiler logic (#2624) docs: add DeployHQ deployment instructions (#2627) docs: fix broken link to issues in CONTRIBUTING.md (#2625) chore: bump rimraf from 5.0.7 to 6.1.0 (#2619) chore: bump @rollup/plugin-commonjs from 28.0.1 to 29.0.0 (#2618) chore: bump actions/setup-node from 5 to 6 (#2620) chore: bump actions/upload-artifact from 4 to 5 (#2621) chore: bump stefanzweifel/git-auto-commit-action from 6 to 7 (#2622) test: improve file embed & code fragment tests (#2617) test: add test for file embed and code fragments (#2616) feat: add fallback default language support (#2607) chore: bump actions/setup-node from 3 to 5 (#2609) chore: bump actions/checkout from 4 to 5 (#2608) docs: Update intro paragraph to help improve first impressions and broaden audience (#2602) feat: enhance embed handling for table cells (#2606) fix: enhance accessibility for sidebar toggle button (#2604) [release] 5.0.0-rc.3 [release] 5.0.0-rc.2 fix: normalize slugs to NFC and remove emoji variation selector (#2597) feat: GitHub style callouts (#2487) ...
Merged
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Background
While generating slugs, we noticed two issues affecting consistency:
Invisible FE0F (Variation Selector-16)
Certain symbols can appear either as text or emoji, depending on whether they are followed by U+FE0F.
If FE0F is not explicitly removed, the slug may contain invisible characters, leading to inconsistent URLs.
NFKD decomposition side effects
Changes
Remove U+FE0F explicitly
Ensures emoji and text variants of the same symbol produce identical slugs.
Example:
Switch normalization from NFKD → NFC
Examples
Related issue, if any:
What kind of change does this PR introduce?
For any code change,
Does this PR introduce a breaking change?
Tested in the following browsers: