FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(ajax): retain response status in cached results by xu91102 · Pull Request #2813 · docsifyjs/docsify · GitHub

  1. docsifyjs
  2. docsify

Repository navigation

fix(ajax): retain response status in cached results #2813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xu91102 wants to merge 2 commits into
base: develop
Choose a base branch
Could not load branches
Branch not found: {{ refName }}

Are you sure you want to change the base?

Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
from
Conversation 2 Commits 2 Checks 5 Files changed
Open

fix(ajax): retain response status in cached results #2813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88020f7
fix(ajax): retain response status in cached results
Sep 26, 2026
abf0602
chore(sync): merge upstream develop into cached response fix
xu91102 Oct 2, 2026
File filter

Filter by extension

Filter by extension .js  (2) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
10 changes: 7 additions & 3 deletions src/core/util/ajax.js
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import progressbar from '../render/progressbar.js';
import { noop } from './core.js';

/** @typedef {{updatedAt: string}} CacheOpt */
/** @typedef {{content: string, opt: CacheOpt}} CacheItem */
/** @typedef {{content: string, opt: CacheOpt, response: ResponseStatus}} CacheItem */
/** @typedef {{ok: boolean, status: number, statusText: string}} ResponseStatus */
/** @type {Record<string, CacheItem>} */

Expand All @@ -30,7 +30,10 @@ export function get(url, hasBar = false, headers = {}) {
const cached = cache[url];

if (cached) {
return { then: cb => cb(cached.content, cached.opt), abort: noop };
return {
then: cb => cb(cached.content, cached.opt, cached.response),
abort: noop,
};
}

xhr.open('GET', url);
Expand Down Expand Up @@ -87,9 +90,10 @@ export function get(url, hasBar = false, headers = {}) {
opt: {
updatedAt: xhr.getResponseHeader('last-modified') ?? '',
},
response: getResponseStatus(event),
});

success(result.content, result.opt, getResponseStatus(event));
success(result.content, result.opt, result.response);
}
});
},
Expand Down
30 changes: 30 additions & 0 deletions test/unit/ajax.test.js
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
import _mock from 'xhr-mock';
import { get } from '../../src/core/util/ajax.js';

const mock = _mock.default;

describe('ajax/get', () => {
beforeEach(() => mock.setup());
afterEach(() => mock.teardown());

test('preserves response status when serving cached content', async () => {
const url = '/cached-response-status.md';
mock.get(url, { status: 200, body: '# Cached page' });

const first = await new Promise(resolve => {
get(url).then((content, opt, response) => {
resolve({ content, opt, response });
});
});
const cached = await new Promise(resolve => {
get(url).then((content, opt, response) => {
resolve({ content, opt, response });
});
});

expect(first.response).toEqual(
expect.objectContaining({ ok: true, status: 200 }),
);
expect(cached).toEqual(first);
});
});
Loading
Back | FazBrowse Home | New Git URL