FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: Added asking whether to rewrite files by sy-records · Pull Request #117 · docsifyjs/docsify-cli · GitHub

/ docsify-cli Public

feat: Added asking whether to rewrite files - #117

Merged
sy-records merged 9 commits into
masterfrom
feat-116
Aug 20, 2020
ConversationCommits (9)ChecksFiles changed
Merged

feat: Added asking whether to rewrite files#117
sy-records merged 9 commits into
masterfrom
feat-116

Conversation

sy-records commented Aug 19, 2020

Copy link
Copy Markdown
Member

close #116

sy-records requested review from anikethsaha and jamesgeorge007 and removed request for anikethsaha August 19, 2020 01:40
jthegedus approved these changes Aug 19, 2020
View reviewed changes

jthegedus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

anikethsaha requested changes Aug 19, 2020
View reviewed changes

anikethsaha left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

optional : can we add a test for this ?

add tests
6448a4e
update
e580505 
fix ci

fix ci

fix ci
sy-records requested a review from anikethsaha August 20, 2020 04:10
jamesgeorge007 reviewed Aug 20, 2020
View reviewed changes
Comment thread lib/commands/init.js Outdated
sy-records merged commit f811906 into master Aug 20, 2020
sy-records deleted the feat-116 branch August 20, 2020 10:11
sy-records mentioned this pull request Apr 28, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

anikethsaha anikethsaha approved these changes
jamesgeorge007 Awaiting requested review from jamesgeorge007
+1 more reviewer
jthegedus jthegedus approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Prevent docsify init ./docs from destroying existing initialization in that folder

4 participants

Back | FazBrowse Home | New Git URL